feat: Spanner Implementation for Vector Store #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- Static Utility to create a table to store vector embeddings - Automatic Dialect Detection for GSQL and PG - Similarity Search & Maximal Marginal Relevance Search - Add documents and texts
…tion & also while creating new table through static utility.
product-auto-label bot added the api: spanner …ad_timestamp and min and exact staleness.
averikitsch requested changes Feb 14, 2024
averikitsch reviewed Feb 16, 2024
Collaborator
averikitsch left a comment
averikitsch left a comment There was a problem hiding this comment.
Will tests also be provided in this PR?
averikitsch reviewed Feb 20, 2024
rahul2393 approved these changes Feb 21, 2024
averikitsch approved these changes Feb 21, 2024
Collaborator
averikitsch left a comment
averikitsch left a comment There was a problem hiding this comment.
Please update the error messages using "id-{" before merging.
* test: Adding integration tests for static utility to create vector embeddings table. * test: Adding add,search,delete integration tests for VectorStore. * test: lint * test: lint * style: lint * style: lint * Empty-Commit to trigger tests * test: addressing review comments. * test: test fix * adding bs4 in test dependencies --------- Co-authored-by: Averi Kitsch <akitsch@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Spanner Implementation for Vector Stores, supports: