Skip to content

feat: Add Spanner Graph QA Chain #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Dec 5, 2024
Merged

feat: Add Spanner Graph QA Chain #111

merged 16 commits into from
Dec 5, 2024

Conversation

@amullick-git
Copy link
Collaborator

@amullick-git amullick-git commented Nov 26, 2024

  1. Add Support for SpannerGraphQAChain following https://api.python.langchain.com/en/latest/chains/langchain.chains.graph_qa.base.GraphQAChain.html
  2. Add integration test
  3. Add a notebook tutorial

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
@amullick-git amullick-git requested review from a team as code owners November 26, 2024 02:47
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/langchain-google-spanner-python API. label Nov 26, 2024
@amullick-git amullick-git changed the title Add Spanner Graph QA Chain feat: Add Spanner Graph QA Chain Nov 26, 2024
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Nov 26, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/
@mtyin
Copy link
Collaborator

mtyin commented Nov 27, 2024

/gcbrun
@amullick-git
Copy link
Collaborator Author

amullick-git commented Nov 27, 2024

/gcbrun
@amullick-git
Copy link
Collaborator Author

amullick-git commented Nov 27, 2024

/gcbrun
1 similar comment
@mtyin
Copy link
Collaborator

mtyin commented Nov 27, 2024

/gcbrun
Make input table name randomized in integration tests to avoid name c…
e0bbdf1 
…ollision for tests running parallely from different python environments
@mtyin
Copy link
Collaborator

mtyin commented Nov 28, 2024

/gcbrun
4 similar comments
@amullick-git
Copy link
Collaborator Author

amullick-git commented Dec 2, 2024

/gcbrun
@amullick-git
Copy link
Collaborator Author

amullick-git commented Dec 2, 2024

/gcbrun
@amullick-git
Copy link
Collaborator Author

amullick-git commented Dec 2, 2024

/gcbrun
@amullick-git
Copy link
Collaborator Author

amullick-git commented Dec 2, 2024

/gcbrun
mtyin
mtyin reviewed Dec 3, 2024
View reviewed changes
mtyin
mtyin reviewed Dec 3, 2024
View reviewed changes
src/langchain_google_spanner/graph_qa.py Outdated
:meta private:
"""
_output_keys = [self.output_key]
Copy link
Collaborator

@mtyin mtyin Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

directly return [self.output_key] ?
Copy link
Collaborator Author

@amullick-git amullick-git Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done
src/langchain_google_spanner/graph_store.py Outdated
for edge in self.schema.edges.values()
]
],
{timeout: 300},
Copy link
Collaborator

@mtyin mtyin Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto
Copy link
Collaborator Author

@amullick-git amullick-git Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed
src/langchain_google_spanner/graph_store.py Outdated
op = self.database.update_ddl(ddl_statements=ddls)
print("Waiting for DDL operations to complete...")
return op.result(options.get("timeout", 60))
return op.result(options.get("timeout", 300))
Copy link
Collaborator

@mtyin mtyin Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should have

DEFAULT_DDL_TIMEOUT = 300

and use it here and in the cleanup function.
Copy link
Collaborator Author

@amullick-git amullick-git Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done
averikitsch
averikitsch reviewed Dec 4, 2024
View reviewed changes
averikitsch
averikitsch reviewed Dec 4, 2024
View reviewed changes
averikitsch
averikitsch reviewed Dec 4, 2024
View reviewed changes
averikitsch
averikitsch reviewed Dec 4, 2024
View reviewed changes
mtyin
mtyin approved these changes Dec 5, 2024
View reviewed changes
@averikitsch averikitsch merged commit e22abde into googleapis:main Dec 5, 2024
11 checks passed
@release-please release-please bot mentioned this pull request Dec 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/langchain-google-spanner-python API.

4 participants

@amullick-git @mtyin @averikitsch @rahul2393