Skip to content

Conversation

@amullick-git
Copy link
Collaborator

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Amarnath Mullick and others added 30 commits November 26, 2024 02:29
…ollision for tests running parallely from different python environments
@amullick-git amullick-git requested review from a team as code owners March 8, 2025 01:30
@product-auto-label product-auto-label bot added api: spanner Issues related to the googleapis/langchain-google-spanner-python API. samples Issues that are directly related to samples. labels Mar 8, 2025
@amullick-git amullick-git assigned mtyin and unassigned mtyin Mar 8, 2025
@amullick-git amullick-git requested a review from mtyin March 8, 2025 01:52
"outputId": "c0e27ce9-6911-4561-d7dc-390462e89463"
},
"execution_count": 2,
"outputs": [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove outputs

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Removed

"!gcloud config set project {PROJECT_ID}\n",
"%env GOOGLE_CLOUD_PROJECT={PROJECT_ID}"
],
"metadata": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section has a nicer view when "cellView": "form" is added to metadata

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

{
"cell_type": "code",
"source": [
"# # Automatically restart kernel after installs so that your environment can access the new packages\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"# # Automatically restart kernel after installs so that your environment can access the new packages\n",
"# Automatically restart kernel after installs so that your environment can access the new packages\n",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Amarnath Mullick added 2 commits March 12, 2025 16:41
Merge branch 'feature/graphrag_blog' of github.com:amullick-git/langchain-google-spanner-python into feature/graphrag_blog
@averikitsch averikitsch merged commit 7ff3620 into googleapis:main Mar 12, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/langchain-google-spanner-python API. samples Issues that are directly related to samples.

4 participants