Skip to content

Conversation

@mtyin
Copy link
Collaborator

@mtyin mtyin commented Apr 24, 2025

…ple element definitions

  1. Allow the same table used to define multiple node/edge definitions;

For example,

 ShareHolding AS PersonOwnsCompany SOURCE Person DESTINATION Company, ShareHolding AS ComanyOwnsCompany SOURCE Company DESTINATION Company, 
  1. Allow graph schema to reference TOKENLIST-typed properties (by
    ignoring them)

    This is a blocker if a customer manually add search index to a
    property and want to use it using graph query language.

…ple element definitions 1) Allow the same table used to define multiple node/edge definitions; For example, ``` ShareHolding AS PersonOwnsCompany SOURCE Person DESTINATION Company, ShareHolding AS ComanyOwnsCompany SOURCE Company DESTINATION Company, ``` 2) Allow graph schema to reference TOKENLIST-typed properties (by ignoring them) This is a blocker if a customer manually add search index to a property and want to use it using graph query language.
@mtyin mtyin requested review from a team as code owners April 24, 2025 00:18
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/langchain-google-spanner-python API. label Apr 24, 2025
Copy link
Collaborator

@amullick-git amullick-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few nits, LGTM

@averikitsch averikitsch merged commit f99c115 into googleapis:main May 13, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/langchain-google-spanner-python API.

4 participants