Skip to content

fix: Make client optional when init #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 3, 2024
Merged

fix: Make client optional when init #60

merged 2 commits into from
May 3, 2024

Conversation

@duwenxin99
Copy link
Contributor

@duwenxin99 duwenxin99 commented May 2, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
@duwenxin99 duwenxin99 requested review from a team as code owners May 2, 2024 17:40
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented May 2, 2024 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/langchain-google-spanner-python API. label May 2, 2024
averikitsch
averikitsch reviewed May 2, 2024
View reviewed changes
src/langchain_google_spanner/vector_store.py
database_id: str,
table_name: str,
client: spanner.Client = spanner.Client(),
client: Optional[spanner.Client] = None,
Copy link
Collaborator

@averikitsch averikitsch May 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that this is None we need to get a client via client_with_user_agent(client, USER_AGENT_VECTOR_STORE)
@averikitsch averikitsch merged commit 0f5124a into main May 3, 2024
@averikitsch averikitsch deleted the client branch May 3, 2024 21:29
@release-please release-please bot mentioned this pull request Apr 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/langchain-google-spanner-python API.

2 participants

@duwenxin99 @averikitsch