Skip to content

Commit 4b08d92

Browse files
authored
fix: address more technical writers feedback (#581)
1 parent c8b137b commit 4b08d92

File tree

15 files changed

+49
-49
lines changed

15 files changed

+49
-49
lines changed

bigframes/_config/compute_options.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
@dataclasses.dataclass
2222
class ComputeOptions:
2323
"""
24-
Encapsulates configuration for compute options.
24+
Encapsulates the configuration for compute options.
2525
2626
**Examples:**
2727
@@ -39,7 +39,7 @@ class ComputeOptions:
3939
Limits the bytes billed for query jobs. Queries that will have
4040
bytes billed beyond this limit will fail (without incurring a
4141
charge). If unspecified, this will be set to your project default.
42-
See `maximum_bytes_billed <https://cloud.google.com/python/docs/reference/bigquery/latest/google.cloud.bigquery.job.QueryJobConfig#google_cloud_bigquery_job_QueryJobConfig_maximum_bytes_billed>`_.
42+
See `maximum_bytes_billed`: https://cloud.google.com/python/docs/reference/bigquery/latest/google.cloud.bigquery.job.QueryJobConfig#google_cloud_bigquery_job_QueryJobConfig_maximum_bytes_billed.
4343
enable_multi_query_execution (bool, Options):
4444
If enabled, large queries may be factored into multiple smaller queries
4545
in order to avoid generating queries that are too complex for the query

bigframes/ml/base.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ def to_gbq(self: _T, model_name: str, replace: bool = False) -> _T:
193193
model_name (str):
194194
The name of the model.
195195
replace (bool, default False):
196-
Whether to replace if the model already exists. Default to False.
196+
Determine whether to replace if the model already exists. Default to False.
197197
198198
Returns:
199199
Saved transformer."""

bigframes/ml/cluster.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ def to_gbq(self, model_name: str, replace: bool = False) -> KMeans:
177177
model_name (str):
178178
the name of the model.
179179
replace (bool, default False):
180-
whether to replace if the model already exists. Default to False.
180+
Determine whether to replace if the model already exists. Default to False.
181181
182182
Returns:
183183
KMeans: saved model."""

bigframes/ml/decomposition.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ def to_gbq(self, model_name: str, replace: bool = False) -> PCA:
171171
model_name (str):
172172
the name of the model.
173173
replace (bool, default False):
174-
whether to replace if the model already exists. Default to False.
174+
Determine whether to replace if the model already exists. Default to False.
175175
176176
Returns:
177177
PCA: saved model."""

bigframes/ml/ensemble.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -192,9 +192,9 @@ def to_gbq(self, model_name: str, replace: bool = False) -> XGBRegressor:
192192
model_name (str):
193193
The name of the model.
194194
replace (bool, default False):
195-
Whether to replace if the model already exists. Default to False.
195+
Determine whether to replace if the model already exists. Default to False.
196196
197-
Returns: saved model."""
197+
Returns: Saved model."""
198198
if not self._bqml_model:
199199
raise RuntimeError("A model must be fitted before it can be saved")
200200

@@ -345,10 +345,10 @@ def to_gbq(self, model_name: str, replace: bool = False) -> XGBClassifier:
345345
model_name (str):
346346
The name of the model.
347347
replace (bool, default False):
348-
Whether to replace if the model already exists. Default to False.
348+
Determine whether to replace if the model already exists. Default to False.
349349
350350
Returns:
351-
XGBClassifier: saved model."""
351+
XGBClassifier: Saved model."""
352352
if not self._bqml_model:
353353
raise RuntimeError("A model must be fitted before it can be saved")
354354

@@ -508,10 +508,10 @@ def to_gbq(self, model_name: str, replace: bool = False) -> RandomForestRegresso
508508
model_name (str):
509509
The name of the model.
510510
replace (bool, default False):
511-
Whether to replace if the model already exists. Default to False.
511+
Determine whether to replace if the model already exists. Default to False.
512512
513513
Returns:
514-
RandomForestRegressor: saved model."""
514+
RandomForestRegressor: Saved model."""
515515
if not self._bqml_model:
516516
raise RuntimeError("A model must be fitted before it can be saved")
517517

@@ -671,10 +671,10 @@ def to_gbq(self, model_name: str, replace: bool = False) -> RandomForestClassifi
671671
model_name (str):
672672
The name of the model.
673673
replace (bool, default False):
674-
Whether to replace if the model already exists. Default to False.
674+
Determine whether to replace if the model already exists. Default to False.
675675
676676
Returns:
677-
RandomForestClassifier: saved model."""
677+
RandomForestClassifier: Saved model."""
678678
if not self._bqml_model:
679679
raise RuntimeError("A model must be fitted before it can be saved")
680680

bigframes/ml/forecasting.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -363,10 +363,10 @@ def to_gbq(self, model_name: str, replace: bool = False) -> ARIMAPlus:
363363
model_name (str):
364364
the name of the model.
365365
replace (bool, default False):
366-
whether to replace if the model already exists. Default to False.
366+
Determine whether to replace if the model already exists. Default to False.
367367
368368
Returns:
369-
ARIMAPlus: saved model."""
369+
ARIMAPlus: Saved model."""
370370
if not self._bqml_model:
371371
raise RuntimeError("A model must be fitted before it can be saved")
372372

bigframes/ml/imported.py

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ class TensorFlowModel(base.Predictor):
3232
3333
Args:
3434
model_path (str):
35-
GCS path that holds the model files.
35+
Cloud Storage path that holds the model files.
3636
session (BigQuery Session):
3737
BQ session to create the model.
3838
"""
@@ -69,10 +69,10 @@ def predict(self, X: Union[bpd.DataFrame, bpd.Series]) -> bpd.DataFrame:
6969
7070
Args:
7171
X (bigframes.dataframe.DataFrame):
72-
Input DataFrame, schema is defined by the model.
72+
Input DataFrame. Schema is defined by the model.
7373
7474
Returns:
75-
bigframes.dataframe.DataFrame: Output DataFrame, schema is defined by the model."""
75+
bigframes.dataframe.DataFrame: Output DataFrame. Schema is defined by the model."""
7676

7777
if not self._bqml_model:
7878
if self.model_path is None:
@@ -91,10 +91,10 @@ def to_gbq(self, model_name: str, replace: bool = False) -> TensorFlowModel:
9191
model_name (str):
9292
the name of the model.
9393
replace (bool, default False):
94-
whether to replace if the model already exists. Default to False.
94+
Default to False.
9595
9696
Returns:
97-
TensorFlowModel: saved model."""
97+
TensorFlowModel: Saved model."""
9898
if not self._bqml_model:
9999
if self.model_path is None:
100100
raise ValueError("Model GCS path must be provided.")
@@ -146,7 +146,7 @@ def predict(self, X: Union[bpd.DataFrame, bpd.Series]) -> bpd.DataFrame:
146146
147147
Args:
148148
X (bigframes.dataframe.DataFrame or bigframes.series.Series):
149-
Input DataFrame or Series, schema is defined by the model.
149+
Input DataFrame or Series. Schema is defined by the model.
150150
151151
Returns:
152152
bigframes.dataframe.DataFrame: Output DataFrame, schema is defined by the model."""
@@ -168,10 +168,10 @@ def to_gbq(self, model_name: str, replace: bool = False) -> ONNXModel:
168168
model_name (str):
169169
the name of the model.
170170
replace (bool, default False):
171-
whether to replace if the model already exists. Default to False.
171+
Determine whether to replace if the model already exists. Default to False.
172172
173173
Returns:
174-
ONNXModel: saved model."""
174+
ONNXModel: Saved model."""
175175
if not self._bqml_model:
176176
if self.model_path is None:
177177
raise ValueError("Model GCS path must be provided.")
@@ -262,10 +262,10 @@ def predict(self, X: Union[bpd.DataFrame, bpd.Series]) -> bpd.DataFrame:
262262
263263
Args:
264264
X (bigframes.dataframe.DataFrame or bigframes.series.Series):
265-
Input DataFrame or Series, schema is defined by the model.
265+
Input DataFrame or Series. Schema is defined by the model.
266266
267267
Returns:
268-
bigframes.dataframe.DataFrame: Output DataFrame, schema is defined by the model."""
268+
bigframes.dataframe.DataFrame: Output DataFrame. Schema is defined by the model."""
269269

270270
if not self._bqml_model:
271271
if self.model_path is None:
@@ -284,10 +284,10 @@ def to_gbq(self, model_name: str, replace: bool = False) -> XGBoostModel:
284284
model_name (str):
285285
the name of the model.
286286
replace (bool, default False):
287-
whether to replace if the model already exists. Default to False.
287+
Determine whether to replace if the model already exists. Default to False.
288288
289289
Returns:
290-
XGBoostModel: saved model."""
290+
XGBoostModel: Saved model."""
291291
if not self._bqml_model:
292292
if self.model_path is None:
293293
raise ValueError("Model GCS path must be provided.")

bigframes/ml/linear_model.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ def to_gbq(self, model_name: str, replace: bool = False) -> LinearRegression:
184184
model_name (str):
185185
the name of the model.
186186
replace (bool, default False):
187-
whether to replace if the model already exists. Default to False.
187+
Determine whether to replace if the model already exists. Default to False.
188188
189189
Returns:
190190
LinearRegression: saved model."""
@@ -349,7 +349,7 @@ def to_gbq(self, model_name: str, replace: bool = False) -> LogisticRegression:
349349
model_name (str):
350350
the name of the model.
351351
replace (bool, default False):
352-
whether to replace if the model already exists. Default to False.
352+
Determine whether to replace if the model already exists. Default to False.
353353
354354
Returns:
355355
LogisticRegression: saved model."""

bigframes/ml/llm.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ def to_gbq(self, model_name: str, replace: bool = False) -> PaLM2TextGenerator:
248248
model_name (str):
249249
the name of the model.
250250
replace (bool, default False):
251-
whether to replace if the model already exists. Default to False.
251+
Determine whether to replace if the model already exists. Default to False.
252252
253253
Returns:
254254
PaLM2TextGenerator: saved model."""
@@ -415,7 +415,7 @@ def to_gbq(
415415
model_name (str):
416416
the name of the model.
417417
replace (bool, default False):
418-
whether to replace if the model already exists. Default to False.
418+
Determine whether to replace if the model already exists. Default to False.
419419
420420
Returns:
421421
PaLM2TextEmbeddingGenerator: saved model."""
@@ -595,7 +595,7 @@ def to_gbq(self, model_name: str, replace: bool = False) -> GeminiTextGenerator:
595595
model_name (str):
596596
the name of the model.
597597
replace (bool, default False):
598-
whether to replace if the model already exists. Default to False.
598+
Determine whether to replace if the model already exists. Default to False.
599599
600600
Returns:
601601
GeminiTextGenerator: saved model."""

third_party/bigframes_vendored/pandas/core/config_init.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
from __future__ import annotations
1414

1515
display_options_doc = """
16-
Encapsulates configuration for displaying objects.
16+
Encapsulates the configuration for displaying objects.
1717
1818
**Examples:**
1919
@@ -79,7 +79,7 @@
7979
"""
8080

8181
sampling_options_doc = """
82-
Encapsulates configuration for data sampling.
82+
Encapsulates the configuration for data sampling.
8383
8484
Attributes:
8585
max_download_size (int, default 500):

0 commit comments

Comments
 (0)