chore: skip small udf tests from system and coverage tests (#1493)

* chore: skip the small udf tests from system and coverage tests * store pytest.mark.skipif in a variable * name `pytestmark` to trigger module level pytest.mark.skipif

Author: shobsi

noxfile.py

@@ -469,6 +469,10 @@ def cover(session):
  "--show-missing",
  "--include=tests/unit/*",
  "--include=tests/system/small/*",
+ # TODO(b/401609005): remove this omission once either the small udf
+ # tests are made to run in system tests or they are moved to large
+ # system tests (aka e2e tests)
+ "--omit=tests/system/small/functions/test_managed_function.py",
  # TODO(b/353775058) resume coverage to 100 when the issue is fixed.
  "--fail-under=99",
  )

tests/system/small/functions/test_managed_function.py

@@ -24,13 +24,15 @@
 import bigframes.series
 from tests.system.utils import assert_pandas_df_equal, get_function_name
 
-bpd.options.experiments.udf = True
-
-
-@pytest.mark.skipif(
+pytestmark = pytest.mark.skipif(
  get_python_version() not in bff_session._MANAGED_FUNC_PYTHON_VERSIONS,
  reason=f"Supported version: {bff_session._MANAGED_FUNC_PYTHON_VERSIONS}",
 )
+
+
+bpd.options.experiments.udf = True
+
+
 @pytest.mark.parametrize(
  ("typ",),
  [
@@ -79,10 +81,6 @@ def foo(x):
  assert_pandas_df_equal(bf_result, pd_result, check_dtype=False)
 
 
-@pytest.mark.skipif(
- get_python_version() not in bff_session._MANAGED_FUNC_PYTHON_VERSIONS,
- reason=f"Supported version: {bff_session._MANAGED_FUNC_PYTHON_VERSIONS}",
-)
 def test_managed_function_series_combine(dataset_id_permanent, scalars_dfs):
  # This function is deliberately written to not work with NA input.
  def add(x: int, y: int) -> int:
@@ -127,10 +125,6 @@ def add(x: int, y: int) -> int:
  pd.testing.assert_series_equal(pd_result, bf_result, check_dtype=False)
 
 
-@pytest.mark.skipif(
- get_python_version() not in bff_session._MANAGED_FUNC_PYTHON_VERSIONS,
- reason=f"Supported version: {bff_session._MANAGED_FUNC_PYTHON_VERSIONS}",
-)
 @pytest.mark.parametrize(
  ("typ",),
  [
@@ -170,10 +164,6 @@ def foo_list(x):
  assert_pandas_df_equal(bf_result, pd_result, check_dtype=False)
 
 
-@pytest.mark.skipif(
- get_python_version() not in bff_session._MANAGED_FUNC_PYTHON_VERSIONS,
- reason=f"Supported version: {bff_session._MANAGED_FUNC_PYTHON_VERSIONS}",
-)
 def test_managed_function_series_combine_list_output(dataset_id_permanent, scalars_dfs):
  def add_list(x: int, y: int) -> list[int]:
  return [x, y]
@@ -209,10 +199,6 @@ def add_list(x: int, y: int) -> list[int]:
  pd.testing.assert_series_equal(pd_result, bf_result, check_dtype=False)
 
 
-@pytest.mark.skipif(
- get_python_version() not in bff_session._MANAGED_FUNC_PYTHON_VERSIONS,
- reason=f"Supported version: {bff_session._MANAGED_FUNC_PYTHON_VERSIONS}",
-)
 def test_managed_function_dataframe_map(scalars_dfs, dataset_id_permanent):
  def add_one(x):
  return x + 1
@@ -244,10 +230,6 @@ def add_one(x):
  assert_pandas_df_equal(bf_result, pd_result)
 
 
-@pytest.mark.skipif(
- get_python_version() not in bff_session._MANAGED_FUNC_PYTHON_VERSIONS,
- reason=f"Supported version: {bff_session._MANAGED_FUNC_PYTHON_VERSIONS}",
-)
 def test_managed_function_dataframe_apply_axis_1(
  session, scalars_dfs, dataset_id_permanent
 ):
@@ -284,10 +266,6 @@ def add_ints(x, y):
  )
 
 
-@pytest.mark.skipif(
- get_python_version() not in bff_session._MANAGED_FUNC_PYTHON_VERSIONS,
- reason=f"Supported version: {bff_session._MANAGED_FUNC_PYTHON_VERSIONS}",
-)
 def test_managed_function_dataframe_map_list_output(scalars_dfs, dataset_id_permanent):
  def add_one_list(x):
  return [x + 1] * 3
@@ -314,10 +292,6 @@ def add_one_list(x):
  assert_pandas_df_equal(bf_result, pd_result, check_dtype=False)
 
 
-@pytest.mark.skipif(
- get_python_version() not in bff_session._MANAGED_FUNC_PYTHON_VERSIONS,
- reason=f"Supported version: {bff_session._MANAGED_FUNC_PYTHON_VERSIONS}",
-)
 def test_managed_function_dataframe_apply_axis_1_list_output(
  session, scalars_dfs, dataset_id_permanent
 ):