fix: exclude DataFrame and Series __call__ from unimplemented API metrics (#1351)

* fix: add feedback link to `DataFrame` and `Series` `__call__` error * revert __call__ add to unimplemented tracking

Author: tswast

bigframes/core/log_adapter.py

@@ -78,7 +78,9 @@ def submit_pandas_labels(
  else:
  return
 
- if hasattr(cls, method_name):
+ # Omit __call__, because its not implemented on the actual instances of
+ # DataFrame/Series, only as the constructor.
+ if method_name != "__call__" and hasattr(cls, method_name):
  method = getattr(cls, method_name)
  else:
  return

tests/unit/core/test_log_adapter.py

@@ -157,11 +157,31 @@ def test_submit_pandas_labels_without_valid_params_for_param_logging(mock_bqclie
  mock_bqclient.query.assert_not_called()
 
 
-def test_submit_pandas_labels_with_internal_method(mock_bqclient):
+@pytest.mark.parametrize(
+ ("class_name", "method_name"),
+ (
+ ("Series", "_repr_latex_"),
+ (
+ "DataFrame",
+ # __call__ should be excluded.
+ # It's implemented on the pd.DataFrame class but not pd.DataFrame instances.
+ "__call__",
+ ),
+ (
+ "Series",
+ # __call__ should be excluded.
+ # It's implemented on the pd.Series class but not pd.Series instances.
+ "__call__",
+ ),
+ ),
+)
+def test_submit_pandas_labels_with_internal_method(
+ mock_bqclient, class_name, method_name
+):
  log_adapter.submit_pandas_labels(
  mock_bqclient,
- "Series",
- "_repr_latex_",
+ class_name,
+ method_name,
  task=log_adapter.PANDAS_API_TRACKING_TASK,
  )
  mock_bqclient.query.assert_not_called()