feat: allow fit to take additional eval data in linear and ensemble models #1096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The additional eval data would be used to measure the fitted model and attach the measurement to the underlying BQML model, which can be used as benchmark for the model consumers in BigQuery Studio and otherwise.
product-auto-label bot added size: l 
shobsi requested review from TrevorBergeron and jiaxunwu and removed request for sycai shobsi changed the title fit to take additional eval data in linear modelsfit to take additional eval data in linear and ensemble models 
jiaxunwu approved these changes Oct 23, 2024
TrevorBergeron approved these changes Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The additional eval data would be used to measure the fitted model and attach the measurement to the underlying BQML model, which can be used as benchmark for the model consumers in BigQuery Studio and otherwise.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
LinearRegression: screenshot/4iDNvucVfsEEZiq,LogisticRegression: screenshot/AqvzuVt4RBPjpw2RandomForestClassifier: screenshot/AGxZJoyRNYdZWY4RandomForestRegressor: screenshot/BuvCqmsp7UJ9CdpXGBClassifier: screenshot/BY7Eb7Ar22zsZBFXGBRegressor: screenshot/66ey2Ci4xWPPU3wFixes internal issue 372344226 🦕