perf: update df.corr, df.cov to be used with more than 30 columns case. #1161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-label bot added size: l 
Genesis929 added kokoro:force-run 
gcf-owl-bot bot removed the owlbot:run 
bigframes-bot removed the kokoro:force-run Genesis929 force-pushed the corr_update_huanc branch from ede6e0b to 0ffa778 Compare Genesis929 added the owlbot:run gcf-owl-bot bot removed the owlbot:run 
sycai approved these changes Dec 4, 2024
bigframes/dataframe.py Outdated
| sort=False, | ||
| ) | ||
| | ||
| frame = DataFrame(block) |
Contributor
There was a problem hiding this comment.
nit: collapse this line with the line below?
bigframes/dataframe.py Outdated
| map_data, | ||
| session=self._get_block().expr.session, | ||
| ).set_index("_bigframes_keys") | ||
| result = result.join(map_df) |
Contributor
There was a problem hiding this comment.
nit: collapse with the line below?
sycai pushed a commit that referenced this pull request Dec 9, 2024
…e. (#1161) * perf: update df.corr, df.cov to be used with more than 30 columns case. * add large test * remove print * fix_index * fix index * test fix * fix test * fix test * slightly improve multi_apply_unary_op to avoid RecursionError * update recursion limit for nox session * skip the test in e2e/python 3.12 * simplify code * simplify code
sycai added a commit that referenced this pull request Dec 10, 2024
…#1189) * feat: Add support for temporal types in dataframe's describe() method * add type hint to make mypy happy * directly use output_type to check agg op support for input type * format code * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * perf: update df.corr, df.cov to be used with more than 30 columns case. (#1161) * perf: update df.corr, df.cov to be used with more than 30 columns case. * add large test * remove print * fix_index * fix index * test fix * fix test * fix test * lint code * fix import path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕