Skip to content

perf: Avoid redundant SQL casts #1399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 19, 2025
Merged

perf: Avoid redundant SQL casts #1399

merged 3 commits into from
Feb 19, 2025

Conversation

@TrevorBergeron
Copy link
Contributor

@TrevorBergeron TrevorBergeron commented Feb 13, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Feb 13, 2025
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Feb 14, 2025
@TrevorBergeron TrevorBergeron marked this pull request as ready for review February 14, 2025 00:55
@TrevorBergeron TrevorBergeron requested review from a team as code owners February 14, 2025 00:55
@tswast
Copy link
Collaborator

tswast commented Feb 19, 2025

Failed e2e test: FAILED tests/system/small/functions/test_remote_function.py::test_skip_bq_connection_check likely unrelated.
tswast
tswast approved these changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@tswast tswast merged commit 6ee48d5 into main Feb 19, 2025
22 of 23 checks passed
@tswast tswast deleted the cancel_causeless_casts branch February 19, 2025 21:59
@release-please release-please bot mentioned this pull request Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

3 participants

@TrevorBergeron @tswast @arwas11