Skip to content

feat!: make remote_function params keyword-only, and default service account explicit #1537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 27, 2025
Merged

feat!: make remote_function params keyword-only, and default service account explicit #1537

merged 12 commits into from
Mar 27, 2025

Conversation

@shobsi
Copy link
Contributor

@shobsi shobsi commented Mar 25, 2025 •
edited
Loading

BEGIN_COMMIT_OVERRIDE
feat!: make remote_function default service account explicit (#1537)

chore!: make remote_function params keyword only (#1537)
END_COMMIT_OVERRIDE

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 364902379 and 394661567 🦕
@shobsi
feat!: make remote_function default service account explicit
f979bd2 
chore!: make `remote_function` params keyword only
@shobsi shobsi requested review from a team as code owners March 25, 2025 08:24
@shobsi shobsi requested a review from Genesis929 March 25, 2025 08:24
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 25, 2025
@shobsi shobsi requested a review from jialuoo March 25, 2025 08:26
@shobsi shobsi requested a review from a team as a code owner March 25, 2025 17:23
@shobsi shobsi requested a review from polong-lin March 25, 2025 17:23
@review-notebook-app
Copy link

review-notebook-app bot commented Mar 25, 2025

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB
@shobsi shobsi changed the title feat!: make remote_function default service account explicit feat!: make remote_function params keyword-only, and default service account explicit Mar 25, 2025
@shobsi shobsi requested review from tswast and removed request for Genesis929 March 26, 2025 07:46
@tswast tswast merged commit 9eb9089 into main Mar 27, 2025
24 checks passed
@tswast tswast deleted the shobs-rf-kwargs branch March 27, 2025 14:58
@release-please release-please bot mentioned this pull request Mar 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.

3 participants

@shobsi @tswast @chelsea-lin