Skip to content

fix: stop ignoring arguments to MatrixFactorization.score(X, y) #1726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 13, 2025
Merged

fix: stop ignoring arguments to MatrixFactorization.score(X, y) #1726

merged 2 commits into from
May 13, 2025

Conversation

@tswast
Copy link
Collaborator

@tswast tswast commented May 13, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
@tswast tswast requested review from a team as code owners May 13, 2025 16:11
@tswast tswast requested a review from ZehaoXU May 13, 2025 16:11
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels May 13, 2025
@tswast tswast requested review from shuoweil and removed request for ZehaoXU May 13, 2025 16:12
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels May 13, 2025
@tswast tswast merged commit 55c07e9 into main May 13, 2025
24 checks passed
@tswast tswast deleted the tswast-matrix-factorization-score branch May 13, 2025 19:59
@release-please release-please bot mentioned this pull request May 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

3 participants

@tswast @shuoweil @jiaxunwu