Skip to content

docs: code samples for dataframe.any, dataframe.all and dataframe.prod #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 22, 2023
Merged

docs: code samples for dataframe.any, dataframe.all and dataframe.prod #223

merged 4 commits into from
Nov 22, 2023

Conversation

@Genesis929
Copy link
Collaborator

@Genesis929 Genesis929 commented Nov 20, 2023 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

dataframe.any: https://screenshot.googleplex.com/3tDhwR9uLRpEZMj
dataframe.all: https://screenshot.googleplex.com/BmCTG4v88CKSzSD
dataframe.prod: https://screenshot.googleplex.com/4yjrcDP72n757hR

Fixes #<issue_number_goes_here> 🦕
@Genesis929 Genesis929 requested review from a team as code owners November 20, 2023 23:45
@Genesis929 Genesis929 requested a review from shobsi November 20, 2023 23:45
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. labels Nov 20, 2023
shobsi
shobsi reviewed Nov 21, 2023
View reviewed changes
ashleyxuu
ashleyxuu reviewed Nov 21, 2023
View reviewed changes
Copy link
Contributor

@ashleyxuu ashleyxuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also do a staging page like: #212 (comment)

You can follow: https://g3doc.corp.google.com/devrel/cloud/infra/devrel_services/g3doc/dev/content_automation/cloud_rad/python.md?cl=head#staging-local-changes-from-github-to-devsite
@Genesis929 Genesis929 merged commit d7957fa into main Nov 22, 2023
@Genesis929 Genesis929 deleted the huanc-stats-docstring-1 branch November 22, 2023 05:26
@release-please release-please bot mentioned this pull request Nov 22, 2023
Merged
Genesis929 added a commit that referenced this pull request Dec 12, 2023
@Genesis929
docs: code samples for dataframe.any, dataframe.all and dataframe.prod (
94e1852 
#223) * docs: code samples for dataframe.any, dataframe.all and dataframe.prod * Update examples * update example output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. size: m Pull request size is medium.

3 participants

@Genesis929 @shobsi @ashleyxuu