Skip to content

feat: specific pyarrow mappings for decimal, bytes types #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Dec 21, 2023
Merged

feat: specific pyarrow mappings for decimal, bytes types #283

merged 9 commits into from
Dec 21, 2023

Conversation

@TrevorBergeron
Copy link
Contributor

@TrevorBergeron TrevorBergeron commented Dec 19, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Dec 19, 2023
@tswast tswast marked this pull request as ready for review December 19, 2023 20:38
@tswast tswast requested review from a team as code owners December 19, 2023 20:38
@tswast tswast requested a review from ashleyxuu December 19, 2023 20:38
@tswast
Copy link
Collaborator

tswast commented Dec 20, 2023

Looks like we have a few more tests to update. I'm actually not sure why we were hoping for "assert isinstance(value, np.ndarray)" in some of those tests. Seems like just checking that "len(value) > 0" would be sufficient.
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Dec 20, 2023
@TrevorBergeron TrevorBergeron merged commit a1c0631 into main Dec 21, 2023
@TrevorBergeron TrevorBergeron deleted the onetype branch December 21, 2023 02:35
@release-please release-please bot mentioned this pull request Dec 21, 2023
Merged
Genesis929 pushed a commit that referenced this pull request Dec 26, 2023
@TrevorBergeron @tswast @Genesis929
feat: specific pyarrow mappings for decimal, bytes types (#283)
0b262c3 
* feat: new bytes, json, decimal type mappings * amend tests to reflect new types * add implicit type conversion for df.replace * more type casting tests * skip pandas 1.x for more tests --------- Co-authored-by: Tim Swast <swast@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.

2 participants

@TrevorBergeron @tswast