Skip to content

perf: simplify join order to use multiple order keys instead of string. #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2023
Merged

perf: simplify join order to use multiple order keys instead of string. #36

merged 1 commit into from
Sep 20, 2023

Conversation

@TrevorBergeron
Copy link
Contributor

@TrevorBergeron TrevorBergeron commented Sep 20, 2023

Change-Id: I8c37e9296b2e4e0ea87f6a7e836d48988d161d37

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
@TrevorBergeron
perf: simplify join order to use multiple order keys instead of string.
6a82b46 
Change-Id: I8c37e9296b2e4e0ea87f6a7e836d48988d161d37
@TrevorBergeron TrevorBergeron requested review from a team as code owners September 20, 2023 20:29
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Sep 20, 2023
@TrevorBergeron
Copy link
Contributor Author

TrevorBergeron commented Sep 20, 2023 •
edited
Loading

Question from @tswast

Can we remove string_encoded now? Or is it still used elsewhere?

We still use string_encoded for concat. I can remove that next, but it will be a bit tricky, so leaving out of this pr.
@tswast tswast merged commit 5056da6 into main Sep 20, 2023
@tswast tswast deleted the jo2git branch September 20, 2023 22:16
@release-please release-please bot mentioned this pull request Sep 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

2 participants

@TrevorBergeron @tswast