Skip to content

fix: downgrade NoDefaultIndexError to DefaultIndexWarning #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2024
Merged

fix: downgrade NoDefaultIndexError to DefaultIndexWarning #658

merged 1 commit into from
May 4, 2024

Conversation

@tswast
Copy link
Collaborator

@tswast tswast commented May 3, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Follow-up to avoid breaking change introduced in #631
🦕
@tswast tswast requested review from a team as code owners May 3, 2024 17:37
@tswast tswast requested a review from shobsi May 3, 2024 17:37
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels May 3, 2024
@tswast tswast mentioned this pull request May 3, 2024
Merged
@shobsi shobsi merged commit 2715d2b into main May 4, 2024
@shobsi shobsi deleted the tswast-DefaultIndexWarning branch May 4, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

3 participants

@tswast @shobsi @stevewalker-de