Skip to content

docs: document inlining of small data in read_* APIs #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 8, 2024
Merged

docs: document inlining of small data in read_* APIs #670

merged 4 commits into from
May 8, 2024

Conversation

@shobsi
Copy link
Contributor

@shobsi shobsi commented May 8, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 336608913 🦕
@shobsi shobsi requested review from a team as code owners May 8, 2024 17:43
@shobsi shobsi requested a review from Genesis929 May 8, 2024 17:43
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels May 8, 2024
@shobsi shobsi requested a review from chelsea-lin May 8, 2024 17:43
milkshakeiii
milkshakeiii approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@milkshakeiii milkshakeiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
chelsea-lin
chelsea-lin approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@chelsea-lin chelsea-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for following up!
@shobsi shobsi merged commit 306953a into main May 8, 2024
@shobsi shobsi deleted the shobs-docs-inline branch May 8, 2024 22:58
@release-please release-please bot mentioned this pull request May 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.

3 participants

@shobsi @milkshakeiii @chelsea-lin