Skip to content

fix: add retry for test_clean_up_via_context_manager #1627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2025
Merged

fix: add retry for test_clean_up_via_context_manager #1627

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8df10db
fix: add retry for test_clean_up_via_context_manager
sycai Apr 17, 2025
40127e6
Merge branch 'main' into sycai_fix
sycai Apr 17, 2025
a248edf
Merge branch 'main' into sycai_fix
sycai Apr 21, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/system/large/test_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ def test_clean_up_by_session_id():
pytest.param(bigframes.connect, id="connect-method"),
],
)
@pytest.mark.flaky(retries=3)
Copy link
Contributor

@shobsi shobsi Apr 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious what flakiness we ran into.. quota issue?
Copy link
Contributor Author

@sycai sycai Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like something about server latency: b/411420369

Example error: https://fusion2.corp.google.com/invocations/8f00eb76-d4fd-4c84-899d-5fbf2645e44c/targets/bigframes%2Fcontinuous%2Fe2e/log
def test_clean_up_via_context_manager(session_creator):
# we will create two tables and confirm that they are deleted
# when the session is closed
Expand Down