Skip to content

refactor: WindowOpNode can create multiple cols #2284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 21, 2025
Merged

refactor: WindowOpNode can create multiple cols #2284

merged 4 commits into from
Nov 21, 2025

Conversation

@TrevorBergeron
Copy link
Contributor

@TrevorBergeron TrevorBergeron commented Nov 20, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Nov 20, 2025
@TrevorBergeron TrevorBergeron requested a review from sycai November 21, 2025 18:09
@TrevorBergeron TrevorBergeron marked this pull request as ready for review November 21, 2025 18:10
@TrevorBergeron TrevorBergeron requested review from a team as code owners November 21, 2025 18:10
tswast
tswast approved these changes Nov 21, 2025
View reviewed changes
.../compile/sqlglot/snapshots/test_compile_window/test_compile_window_w_groupby_rolling/out.sql
Copy link
Collaborator

@tswast tswast Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplificiation! Was this expected? Looks like dropping a simulated join case statement.
@TrevorBergeron TrevorBergeron merged commit ac43ee5 into main Nov 21, 2025
23 of 24 checks passed
@TrevorBergeron TrevorBergeron deleted the multi_col_windowing branch November 21, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.

3 participants

@TrevorBergeron @tswast @liujiashang