Skip to content
This repository was archived by the owner on Jul 6, 2023. It is now read-only.

Commit 71f74bf

Browse files
fix: Updated resource patterns to comply with https://google.aip.dev/123#annotating-resource-types (#17)
PiperOrigin-RevId: 438230444 Source-Link: googleapis/googleapis@1821985 Source-Link: https://github.com/googleapis/googleapis-gen/commit/30cb53f99d252b366aa837b38cf9d1f8b283ec4a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzBjYjUzZjk5ZDI1MmIzNjZhYTgzN2IzOGNmOWQxZjhiMjgzZWM0YSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent 5078213 commit 71f74bf

File tree

3 files changed

+22
-19
lines changed

3 files changed

+22
-19
lines changed

google/cloud/certificate_manager_v1/services/certificate_manager/client.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -291,20 +291,20 @@ def parse_dns_authorization_path(path: str) -> Dict[str, str]:
291291
def target_https_proxies_path(
292292
project: str,
293293
location: str,
294-
targetHttpsProxy: str,
294+
target_https_proxy: str,
295295
) -> str:
296296
"""Returns a fully-qualified target_https_proxies string."""
297-
return "projects/{project}/locations/{location}/targetHttpsProxies/{targetHttpsProxy}".format(
297+
return "projects/{project}/locations/{location}/targetHttpsProxies/{target_https_proxy}".format(
298298
project=project,
299299
location=location,
300-
targetHttpsProxy=targetHttpsProxy,
300+
target_https_proxy=target_https_proxy,
301301
)
302302

303303
@staticmethod
304304
def parse_target_https_proxies_path(path: str) -> Dict[str, str]:
305305
"""Parses a target_https_proxies path into its component segments."""
306306
m = re.match(
307-
r"^projects/(?P<project>.+?)/locations/(?P<location>.+?)/targetHttpsProxies/(?P<targetHttpsProxy>.+?)$",
307+
r"^projects/(?P<project>.+?)/locations/(?P<location>.+?)/targetHttpsProxies/(?P<target_https_proxy>.+?)$",
308308
path,
309309
)
310310
return m.groupdict() if m else {}
@@ -313,20 +313,20 @@ def parse_target_https_proxies_path(path: str) -> Dict[str, str]:
313313
def target_ssl_proxies_path(
314314
project: str,
315315
location: str,
316-
targetSslProxy: str,
316+
target_ssl_proxy: str,
317317
) -> str:
318318
"""Returns a fully-qualified target_ssl_proxies string."""
319-
return "projects/{project}/locations/{location}/targetSslProxies/{targetSslProxy}".format(
319+
return "projects/{project}/locations/{location}/targetSslProxies/{target_ssl_proxy}".format(
320320
project=project,
321321
location=location,
322-
targetSslProxy=targetSslProxy,
322+
target_ssl_proxy=target_ssl_proxy,
323323
)
324324

325325
@staticmethod
326326
def parse_target_ssl_proxies_path(path: str) -> Dict[str, str]:
327327
"""Parses a target_ssl_proxies path into its component segments."""
328328
m = re.match(
329-
r"^projects/(?P<project>.+?)/locations/(?P<location>.+?)/targetSslProxies/(?P<targetSslProxy>.+?)$",
329+
r"^projects/(?P<project>.+?)/locations/(?P<location>.+?)/targetSslProxies/(?P<target_ssl_proxy>.+?)$",
330330
path,
331331
)
332332
return m.groupdict() if m else {}

google/cloud/certificate_manager_v1/types/certificate_manager.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -849,7 +849,10 @@ class Certificate(proto.Message):
849849
san_dnsnames (Sequence[str]):
850850
Output only. The list of Subject Alternative
851851
Names of dnsName type defined in the certificate
852-
(see RFC 5280 4.2.1.6)
852+
(see RFC 5280 4.2.1.6). Managed certificates
853+
that haven't been provisioned yet have this
854+
field populated with a value of the
855+
managed.domains field.
853856
pem_certificate (str):
854857
Output only. The PEM-encoded certificate
855858
chain.

tests/unit/gapic/certificate_manager_v1/test_certificate_manager.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7099,14 +7099,14 @@ def test_parse_dns_authorization_path():
70997099
def test_target_https_proxies_path():
71007100
project = "whelk"
71017101
location = "octopus"
7102-
targetHttpsProxy = "oyster"
7103-
expected = "projects/{project}/locations/{location}/targetHttpsProxies/{targetHttpsProxy}".format(
7102+
target_https_proxy = "oyster"
7103+
expected = "projects/{project}/locations/{location}/targetHttpsProxies/{target_https_proxy}".format(
71047104
project=project,
71057105
location=location,
7106-
targetHttpsProxy=targetHttpsProxy,
7106+
target_https_proxy=target_https_proxy,
71077107
)
71087108
actual = CertificateManagerClient.target_https_proxies_path(
7109-
project, location, targetHttpsProxy
7109+
project, location, target_https_proxy
71107110
)
71117111
assert expected == actual
71127112

@@ -7115,7 +7115,7 @@ def test_parse_target_https_proxies_path():
71157115
expected = {
71167116
"project": "nudibranch",
71177117
"location": "cuttlefish",
7118-
"targetHttpsProxy": "mussel",
7118+
"target_https_proxy": "mussel",
71197119
}
71207120
path = CertificateManagerClient.target_https_proxies_path(**expected)
71217121

@@ -7127,14 +7127,14 @@ def test_parse_target_https_proxies_path():
71277127
def test_target_ssl_proxies_path():
71287128
project = "winkle"
71297129
location = "nautilus"
7130-
targetSslProxy = "scallop"
7131-
expected = "projects/{project}/locations/{location}/targetSslProxies/{targetSslProxy}".format(
7130+
target_ssl_proxy = "scallop"
7131+
expected = "projects/{project}/locations/{location}/targetSslProxies/{target_ssl_proxy}".format(
71327132
project=project,
71337133
location=location,
7134-
targetSslProxy=targetSslProxy,
7134+
target_ssl_proxy=target_ssl_proxy,
71357135
)
71367136
actual = CertificateManagerClient.target_ssl_proxies_path(
7137-
project, location, targetSslProxy
7137+
project, location, target_ssl_proxy
71387138
)
71397139
assert expected == actual
71407140

@@ -7143,7 +7143,7 @@ def test_parse_target_ssl_proxies_path():
71437143
expected = {
71447144
"project": "abalone",
71457145
"location": "squid",
7146-
"targetSslProxy": "clam",
7146+
"target_ssl_proxy": "clam",
71477147
}
71487148
path = CertificateManagerClient.target_ssl_proxies_path(**expected)
71497149

0 commit comments

Comments
 (0)