Skip to content

Conversation

@rahul2393
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@rahul2393 rahul2393 requested review from a team as code owners March 6, 2024 09:44
@rahul2393 rahul2393 requested a review from nicain March 6, 2024 09:44
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Mar 6, 2024
@snippet-bot
Copy link

snippet-bot bot commented Mar 6, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment
@product-auto-label product-auto-label bot added api: spanner Issues related to the googleapis/python-spanner API. samples Issues that are directly related to samples. labels Mar 6, 2024
@rahul2393 rahul2393 requested review from arpan14 and harshachinta and removed request for nicain March 6, 2024 09:47
@rahul2393 rahul2393 requested a review from surbhigarg92 March 6, 2024 09:49
@harshachinta
Copy link
Contributor

LGTM, with some minor sample comments

@rahul2393 rahul2393 enabled auto-merge (squash) March 7, 2024 07:01
@rahul2393 rahul2393 merged commit e73c671 into main Mar 7, 2024
@rahul2393 rahul2393 deleted the managed_autoscalar branch March 7, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/python-spanner API. samples Issues that are directly related to samples. size: m Pull request size is medium.

2 participants