Skip to content

fix: don't use a list for empty arguments #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2022
Merged

fix: don't use a list for empty arguments #750

merged 1 commit into from
Jun 17, 2022

Conversation

@IlyaFaer
Copy link
Contributor

@IlyaFaer IlyaFaer commented Jun 17, 2022 •
edited
Loading

On SQLAlchemy dialect label I've noticed an error:

File "/home/runner/work/python-spanner-sqlalchemy/python-spanner-sqlalchemy/.nox/compliance_test_13/lib/python3.8/site-packages/google/cloud/spanner_dbapi/connection.py", line 437, in run_statement _execute_insert_heterogenous( File "/home/runner/work/python-spanner-sqlalchemy/python-spanner-sqlalchemy/.nox/compliance_test_13/lib/python3.8/site-packages/google/cloud/spanner_dbapi/_helpers.py", line 53, in _execute_insert_heterogenous transaction.execute_update(sql, params, get_param_types(params)) File "/home/runner/work/python-spanner-sqlalchemy/python-spanner-sqlalchemy/.nox/compliance_test_13/lib/python3.8/site-packages/google/cloud/spanner_dbapi/parse_utils.py", line 287, in get_param_types for key, value in params.items(): AttributeError: 'list' object has no attribute 'items'

This tiny change fixes the error.
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/python-spanner API. labels Jun 17, 2022
@IlyaFaer IlyaFaer marked this pull request as ready for review June 17, 2022 14:50
@IlyaFaer IlyaFaer requested review from a team as code owners June 17, 2022 14:50
@IlyaFaer IlyaFaer mentioned this pull request Jun 17, 2022
Merged
@IlyaFaer IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 17, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 17, 2022
@IlyaFaer IlyaFaer merged commit 5d8b055 into googleapis:main Jun 17, 2022
@IlyaFaer IlyaFaer deleted the empty_args branch June 17, 2022 19:57
@release-please release-please bot mentioned this pull request Jun 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/python-spanner API. size: xs Pull request size is extra small.

3 participants

@IlyaFaer @asthamohta @yoshi-kokoro