Skip to content

Conversation

@easwars
Copy link
Contributor

@easwars easwars commented Jun 24, 2025

This is a follow-up from #8405.

Exporting this type will allow the registration of other resource type implementations. Currently this is in an internal package, and we will anyway get rid of this code once we migrate all our resource type implementations to use the new generic client API directly. This is only a temporary hack.

RELEASE NOTES: none

@easwars easwars requested a review from arjan-bal June 24, 2025 11:56
@easwars easwars added the Type: Internal Cleanup Refactors, etc label Jun 24, 2025
@easwars easwars added this to the 1.74 Release milestone Jun 24, 2025
@codecov
Copy link

codecov bot commented Jun 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.39%. Comparing base (15299cc) to head (11807a1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@ ## master #8406 +/- ## ========================================== + Coverage 82.29% 82.39% +0.10%  ========================================== Files 414 414 Lines 40420 40420 ========================================== + Hits 33263 33305 +42  + Misses 5789 5757 -32  + Partials 1368 1358 -10 
Files with missing lines Coverage Δ
...nal/xdsclient/xdsresource/cluster_resource_type.go 78.37% <100.00%> (ø)
...l/xdsclient/xdsresource/endpoints_resource_type.go 76.47% <100.00%> (ø)
...al/xdsclient/xdsresource/listener_resource_type.go 86.44% <100.00%> (ø)
...ds/internal/xdsclient/xdsresource/resource_type.go 59.67% <100.00%> (ø)
...dsclient/xdsresource/route_config_resource_type.go 76.47% <100.00%> (ø)

... and 22 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@arjan-bal arjan-bal assigned easwars and unassigned arjan-bal Jun 24, 2025
@easwars easwars merged commit 1787f94 into grpc:master Jun 25, 2025
24 of 27 checks passed
@easwars easwars deleted the export_genericResourceTypeDecoder branch June 25, 2025 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants