Skip to content

Conversation

@mmichel11
Copy link
Contributor

@mmichel11 mmichel11 commented Nov 19, 2025

  • Adds submit_graph_direct_with_event_impl and submit_graph_direct_without_event_impl to the ABI which invoke a handler-less path for graph submission for queue::ext_oneapi_graph and the free function execute_graph.
  • Adjusts handler-less submit_direct utility to be more general: support submissions which may contain host task, move scheduler bypass logic to callback functor, and parameterize submission CGType.
  • Extends graph test coverage to cover identified gaps: recording handler-less graph submission and host task cases with dependencies.
@mmichel11 mmichel11 force-pushed the matt/handlerless_graph_submit branch from 5dc81c5 to 098a334 Compare November 19, 2025 19:49
@mmichel11 mmichel11 force-pushed the matt/handlerless_graph_submit branch from 098a334 to 3617bc9 Compare November 19, 2025 20:36
@mmichel11 mmichel11 force-pushed the matt/handlerless_graph_submit branch from e3a6ba2 to da7910d Compare November 20, 2025 04:43
@mmichel11 mmichel11 marked this pull request as ready for review November 20, 2025 19:12
@mmichel11 mmichel11 requested review from a team as code owners November 20, 2025 19:12
Copy link
Contributor

@slawekptak slawekptak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that overall the changes look great. Added a few minor comments.

* Use !MEmpty instead of MNoLastEventMode in handler-less path * Styling / variable naming
Copy link
Contributor

@reble reble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmichel11
Copy link
Contributor Author

mmichel11 commented Dec 1, 2025

After sync with sycl, the L0 leak case no longer shows up for host_task_in_order_dependency, so I removed the xfail. A warning with older GCC versions was also fixed.

@againull againull merged commit b334921 into intel:sycl Dec 1, 2025
75 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants