- Notifications
You must be signed in to change notification settings - Fork 798
[SYCL][Graph] Add support for handler-less graph submission #20690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5dc81c5 to 098a334 Compare 098a334 to 3617bc9 Compare e3a6ba2 to da7910d Compare da7910d to 7642921 Compare
slawekptak left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that overall the changes look great. Added a few minor comments.
* Use !MEmpty instead of MNoLastEventMode in handler-less path * Styling / variable naming
reble left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| After sync with sycl, the L0 leak case no longer shows up for |
submit_graph_direct_with_event_implandsubmit_graph_direct_without_event_implto the ABI which invoke a handler-less path for graph submission forqueue::ext_oneapi_graphand the free functionexecute_graph.submit_directutility to be more general: support submissions which may contain host task, move scheduler bypass logic to callback functor, and parameterize submission CGType.