Skip to content

Commit 7e9b9cf

Browse files
committed
Regenerate session on login.
1 parent 5e6d92f commit 7e9b9cf

File tree

1 file changed

+20
-10
lines changed

1 file changed

+20
-10
lines changed

lib/sessionmanager.js

Lines changed: 20 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,24 +10,34 @@ function SessionManager(options, serializeUser) {
1010
}
1111

1212
SessionManager.prototype.logIn = function(req, user, cb) {
13+
console.log('SM: logIn');
14+
1315
var self = this;
14-
this._serializeUser(user, req, function(err, obj) {
16+
req.session.regenerate(function(err) {
1517
if (err) {
1618
return cb(err);
1719
}
18-
// TODO: Error if session isn't available here.
19-
if (!req.session) {
20-
req.session = {};
21-
}
22-
if (!req.session[self._key]) {
23-
req.session[self._key] = {};
24-
}
25-
req.session[self._key].user = obj;
26-
cb();
20+
21+
self._serializeUser(user, req, function(err, obj) {
22+
if (err) {
23+
return cb(err);
24+
}
25+
// TODO: Error if session isn't available here.
26+
if (!req.session) {
27+
req.session = {};
28+
}
29+
if (!req.session[self._key]) {
30+
req.session[self._key] = {};
31+
}
32+
req.session[self._key].user = obj;
33+
cb();
34+
});
2735
});
2836
}
2937

3038
SessionManager.prototype.logOut = function(req, cb) {
39+
console.log('SM: logOut');
40+
3141
if (req.session && req.session[this._key]) {
3242
delete req.session[this._key].user;
3343
}

0 commit comments

Comments
 (0)