powerpc: net: bpf_jit_comp: Fix misuse of fallthrough #119
Conversation
| Master branch: ba5f4cf Pull request is NOT updated. Failed to apply https://patchwork.ozlabs.org/project/netdev/list/?series=204533, error message: |
| Master branch: ba5f4cf |
kernel-patches-bot force-pushed the series/204533=>bpf-next branch from becab04 to 6ebfab9 Compare | Master branch: 1fd17c8 |
kernel-patches-bot force-pushed the series/204533=>bpf-next branch from 6ebfab9 to d44a68b Compare | Master branch: 09d8ad1 |
kernel-patches-bot force-pushed the series/204533=>bpf-next branch from d44a68b to 157f644 Compare | Master branch: efa90b5 |
kernel-patches-bot force-pushed the series/204533=>bpf-next branch from 157f644 to 737f8ad Compare | Master branch: 84a20d8 |
kernel-patches-bot force-pushed the series/204533=>bpf-next branch from 737f8ad to e296f61 Compare | Master branch: b000def |
kernel-patches-bot force-pushed the series/204533=>bpf-next branch from e296f61 to 1211fdd Compare | Master branch: a871b04 |
kernel-patches-bot force-pushed the series/204533=>bpf-next branch from 1211fdd to bd9bf67 Compare | Master branch: 98b972d |
kernel-patches-bot force-pushed the series/204533=>bpf-next branch from bd9bf67 to 34de395 Compare | Master branch: bc60090 |
kernel-patches-bot force-pushed the series/204533=>bpf-next branch from 34de395 to 141a9ee Compare | Master branch: 00e8c44 |
kernel-patches-bot force-pushed the series/204533=>bpf-next branch from 141a9ee to ae6aa02 Compare | Master branch: 9d9aae5 |
kernel-patches-bot force-pushed the series/204533=>bpf-next branch from ae6aa02 to 1e94931 Compare | Master branch: f1fc8ec |
kernel-patches-bot force-pushed the series/204533=>bpf-next branch from 1e94931 to b4e2fb1 Compare | Master branch: f970cbc |
kernel-patches-bot force-pushed the series/204533=>bpf-next branch from b4e2fb1 to d592ec2 Compare | Master branch: 85e3f31 |
kernel-patches-bot force-pushed the series/204533=>bpf-next branch from d592ec2 to fbe881b Compare The user defined label following "fallthrough" is not considered by GCC and causes build failure. kernel-source/include/linux/compiler_attributes.h:208:41: error: attribute 'fallthrough' not preceding a case label or default label [-Werror] 208 define fallthrough _attribute((fallthrough_)) ^~~~~~~~~~~~~ Signed-off-by: He Zhe <zhe.he@windriver.com>
| Master branch: c810b31 |
kernel-patches-bot force-pushed the series/204533=>bpf-next branch from fbe881b to a59a104 Compare 
Like commit 1cf3bfc ("bpf: Support 64-bit pointers to kfuncs") for s390x, add support for 64-bit pointers to kfuncs for LoongArch. Since the infrastructure is already implemented in BPF core, the only thing need to be done is to override bpf_jit_supports_far_kfunc_call(). Before this change, several test_verifier tests failed: # ./test_verifier | grep # | grep FAIL #119/p calls: invalid kfunc call: ptr_to_mem to struct with non-scalar FAIL #120/p calls: invalid kfunc call: ptr_to_mem to struct with nesting depth > 4 FAIL #121/p calls: invalid kfunc call: ptr_to_mem to struct with FAM FAIL #122/p calls: invalid kfunc call: reg->type != PTR_TO_CTX FAIL #123/p calls: invalid kfunc call: void * not allowed in func proto without mem size arg FAIL #124/p calls: trigger reg2btf_ids[reg->type] for reg->type > __BPF_REG_TYPE_MAX FAIL #125/p calls: invalid kfunc call: reg->off must be zero when passed to release kfunc FAIL #126/p calls: invalid kfunc call: don't match first member type when passed to release kfunc FAIL #127/p calls: invalid kfunc call: PTR_TO_BTF_ID with negative offset FAIL #128/p calls: invalid kfunc call: PTR_TO_BTF_ID with variable offset FAIL #129/p calls: invalid kfunc call: referenced arg needs refcounted PTR_TO_BTF_ID FAIL #130/p calls: valid kfunc call: referenced arg needs refcounted PTR_TO_BTF_ID FAIL #486/p map_kptr: ref: reference state created and released on xchg FAIL This is because the kfuncs in the loaded module are far away from __bpf_call_base: ffff800002009440 t bpf_kfunc_call_test_fail1 [bpf_testmod] 9000000002e128d8 T __bpf_call_base The offset relative to __bpf_call_base does NOT fit in s32, which breaks the assumption in BPF core. Enable bpf_jit_supports_far_kfunc_call() lifts this limit. Note that to reproduce the above result, tools/testing/selftests/bpf/config should be applied, and run the test with JIT enabled, unpriv BPF enabled. With this change, the test_verifier tests now all passed: # ./test_verifier ... Summary: 777 PASSED, 0 SKIPPED, 0 FAILED Tested-by: Tiezhu Yang <yangtiezhu@loongson.cn> Signed-off-by: Hengqi Chen <hengqi.chen@gmail.com> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
Pull request for series with
subject: powerpc: net: bpf_jit_comp: Fix misuse of fallthrough
version: 1
url: https://patchwork.ozlabs.org/project/netdev/list/?series=204533