Standarize reflection usage (#424)

Author: kubawerlos

dev-tools/src/Readme/ReadmeCommand.php

@@ -173,11 +173,11 @@ private function fixers(): string
 
  /** @var AbstractFixer $fixer */
  foreach (new Fixers() as $fixer) {
- $reflection = new \ReflectionClass($fixer);
+ $reflectionClass = new \ReflectionClass($fixer);
 
  $output .= \sprintf(
  "\n#### %s\n%s",
- $reflection->getShortName(),
+ $reflectionClass->getShortName(),
  $fixer->getDefinition()->getSummary()
  );
 

tests/AutoReview/SrcCodeTest.php

@@ -58,7 +58,7 @@ public function testFixerHasValidName(FixerInterface $fixer): void
  */
  public function testFixerIsFinal(FixerInterface $fixer): void
  {
- self::assertTrue((new \ReflectionClass($fixer))->isFinal());
+ self::assertTrue((new \ReflectionObject($fixer))->isFinal());
  }
 
  /**
@@ -74,7 +74,7 @@ public function testFixerIsNotBothDeprecatingAndDeprecated(FixerInterface $fixer
  */
  public function testDeprecatedFixerHasAnnotation(FixerInterface $fixer): void
  {
- $comment = (new \ReflectionClass($fixer))->getDocComment();
+ $comment = (new \ReflectionObject($fixer))->getDocComment();
  self::assertSame(
  $fixer instanceof DeprecatedFixerInterface,
  \strpos($comment === false ? '' : $comment, '@deprecated') !== false
@@ -103,8 +103,8 @@ public function testFixerSupportsAllFilesByDefault(): void
  */
  public function testThereIsNoPregFunctionUsedDirectly(string $className): void
  {
- $rc = new \ReflectionClass($className);
- $tokens = Tokens::fromCode(\file_get_contents($rc->getFileName()));
+ $reflectionClass = new \ReflectionClass($className);
+ $tokens = Tokens::fromCode(\file_get_contents($reflectionClass->getFileName()));
  $stringTokens = \array_filter(
  $tokens->toArray(),
  static function (Token $token): bool {

tests/AutoReview/TestsCodeTest.php

@@ -95,11 +95,11 @@ public static function provideDataProviderCases(): iterable
  */
  private static function getDataProviderMethodNames(string $className): array
  {
- $reflection = new \ReflectionClass($className);
+ $reflectionClass = new \ReflectionClass($className);
 
  $dataProviderMethodNames = [];
 
- foreach ($reflection->getMethods(\ReflectionMethod::IS_PUBLIC) as $method) {
+ foreach ($reflectionClass->getMethods(\ReflectionMethod::IS_PUBLIC) as $method) {
  $docBlock = new DocBlock($method->getDocComment());
  $dataProviderAnnotations = $docBlock->getAnnotationsOfType('dataProvider');
 

tests/Fixer/SingleSpaceAfterStatementFixerTest.php

@@ -289,8 +289,8 @@ public function testTokenIsUseful(int $token): void
  $expectedTokens = Tokens::fromCode(self::EXAMPLE_WITH_ALL_TOKENS);
  $this->fixer->fix($this->createMock(\SplFileInfo::class), $expectedTokens);
 
- $reflection = new \ReflectionClass($this->fixer);
- $property = $reflection->getProperty('tokens');
+ $reflectionObject = new \ReflectionObject($this->fixer);
+ $property = $reflectionObject->getProperty('tokens');
  $property->setAccessible(true);
  $property->setValue($this->fixer, \array_diff($property->getValue($this->fixer), [$token]));
 
@@ -307,8 +307,8 @@ public function testTokenIsUseful(int $token): void
  public static function provideTokenIsUsefulCases(): iterable
  {
  $fixer = new SingleSpaceAfterStatementFixer();
- $reflection = new \ReflectionClass($fixer);
- $property = $reflection->getProperty('tokens');
+ $reflectionObject = new \ReflectionObject($fixer);
+ $property = $reflectionObject->getProperty('tokens');
  $property->setAccessible(true);
 
  foreach ($property->getValue($fixer) as $token) {