Change source.url in rockspec to use git+https:// instead of git:// protocol (deprecated by GitHub) #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
GitHub deprecated usage of `git://` (unencrypted Git protocol) on March 15th, 2022.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
GitHub deprecated usage of
git://(unencrypted Git protocol) on March 15th, 2022, so LuaRocks will fail to install any package including asource.urlstarting withgit://. According to the LuaRocks documentation, the correct syntax for referencinghttps://URLs isgit+https://.This PR fixes
source.urlin the.rockspecfile and bumps the version. I checked out the branch frommaster. I also made a second PR (attempting to) backport the fix tov0.16.x: #271P.S. If your CI is breaking from luarocks packages using
git://, here is a quick fix you can use: