Skip to content

Commit fa151a3

Browse files
lostjeffleakpm00
authored andcommitted
mm: fix arithmetic for max_prop_frac when setting max_ratio
Since now bdi->max_ratio is part per million, fix the wrong arithmetic for max_prop_frac when setting max_ratio. Otherwise the miscalculated max_prop_frac will affect the incrementing of writeout completion count when max_ratio is not 100%. Link: https://lkml.kernel.org/r/20231219142508.86265-3-jefflexu@linux.alibaba.com Fixes: efc3e6a ("mm: split off __bdi_set_max_ratio() function") Signed-off-by: Jingbo Xu <jefflexu@linux.alibaba.com> Cc: Joseph Qi <joseph.qi@linux.alibaba.com> Cc: Matthew Wilcox (Oracle) <willy@infradead.org> Cc: Stefan Roesch <shr@devkernel.io> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent e0646b7 commit fa151a3

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

mm/page-writeback.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -728,7 +728,8 @@ static int __bdi_set_max_ratio(struct backing_dev_info *bdi, unsigned int max_ra
728728
ret = -EINVAL;
729729
} else {
730730
bdi->max_ratio = max_ratio;
731-
bdi->max_prop_frac = (FPROP_FRAC_BASE * max_ratio) / 100;
731+
bdi->max_prop_frac = (FPROP_FRAC_BASE * max_ratio) /
732+
(100 * BDI_RATIO_SCALE);
732733
}
733734
spin_unlock_bh(&bdi_lock);
734735

0 commit comments

Comments
 (0)