Skip to content

[CIR] Fix RTTI mangling assertion with qualified types #2002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: gh/lanza/6/base
Choose a base branch
from
Draft

[CIR] Fix RTTI mangling assertion with qualified types #2002

wants to merge 3 commits into from

Conversation

@lanza
Copy link
Member

@lanza lanza commented Nov 22, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Fixes an assertion failure when creating RTTI descriptors for types
with top-level qualifiers (const, volatile, etc.). The Itanium C++ ABI
requires that RTTI descriptors be created for unqualified types only,
but ClangIR was passing qualified types to the mangling function.

The fix strips qualifiers in BuildTypeInfo before mangling, matching
the behavior of traditional CodeGen. Also strips qualifiers when
getting RTTI descriptors for dynamic_cast operands, consistent with
CodeGen's implementation.

This fixes std::regex usage and other cases where qualified types
are used with typeid or dynamic_cast.
@lanza
Update
96157c0 
[ghstack-poisoned]
lanza added a commit that referenced this pull request Nov 22, 2025
@lanza
[CIR] Fix RTTI mangling assertion with qualified types
c4896d2 
Fixes an assertion failure when creating RTTI descriptors for types with top-level qualifiers (const, volatile, etc.). The Itanium C++ ABI requires that RTTI descriptors be created for unqualified types only, but ClangIR was passing qualified types to the mangling function. The fix strips qualifiers in BuildTypeInfo before mangling, matching the behavior of traditional CodeGen. Also strips qualifiers when getting RTTI descriptors for dynamic_cast operands, consistent with CodeGen's implementation. This fixes std::regex usage and other cases where qualified types are used with typeid or dynamic_cast. ghstack-source-id: 3c9ffe9 Pull-Request: #2002
This was referenced Nov 22, 2025
Draft
Draft
Draft
@lanza
Update
ddaaf62 
[ghstack-poisoned]
This was referenced Nov 22, 2025
Closed
Draft
Closed
Draft
Draft
lanza added a commit that referenced this pull request Nov 24, 2025
@lanza
[CIR] Fix RTTI mangling assertion with qualified types
c620112 
Fixes an assertion failure when creating RTTI descriptors for types with top-level qualifiers (const, volatile, etc.). The Itanium C++ ABI requires that RTTI descriptors be created for unqualified types only, but ClangIR was passing qualified types to the mangling function. The fix strips qualifiers in BuildTypeInfo before mangling, matching the behavior of traditional CodeGen. Also strips qualifiers when getting RTTI descriptors for dynamic_cast operands, consistent with CodeGen's implementation. This fixes std::regex usage and other cases where qualified types are used with typeid or dynamic_cast. ghstack-source-id: e18ff76 Pull-Request: #2002
@lanza
Update
d28ff82 
[ghstack-poisoned]
This was referenced Nov 24, 2025
Draft
Draft
Draft
Draft
Draft
@lanza lanza marked this pull request as draft November 24, 2025 18:39
lanza added a commit that referenced this pull request Nov 25, 2025
@lanza
[CIR] Fix RTTI mangling assertion with qualified types
3f2f01c 
Fixes an assertion failure when creating RTTI descriptors for types with top-level qualifiers (const, volatile, etc.). The Itanium C++ ABI requires that RTTI descriptors be created for unqualified types only, but ClangIR was passing qualified types to the mangling function. The fix strips qualifiers in BuildTypeInfo before mangling, matching the behavior of traditional CodeGen. Also strips qualifiers when getting RTTI descriptors for dynamic_cast operands, consistent with CodeGen's implementation. This fixes std::regex usage and other cases where qualified types are used with typeid or dynamic_cast. ghstack-source-id: e18ff76 Pull-Request: #2002
lanza added a commit that referenced this pull request Nov 25, 2025
@lanza
[CIR] Fix RTTI mangling assertion with qualified types
00ecc5a 
Fixes an assertion failure when creating RTTI descriptors for types with top-level qualifiers (const, volatile, etc.). The Itanium C++ ABI requires that RTTI descriptors be created for unqualified types only, but ClangIR was passing qualified types to the mangling function. The fix strips qualifiers in BuildTypeInfo before mangling, matching the behavior of traditional CodeGen. Also strips qualifiers when getting RTTI descriptors for dynamic_cast operands, consistent with CodeGen's implementation. This fixes std::regex usage and other cases where qualified types are used with typeid or dynamic_cast. ghstack-source-id: e18ff76 Pull-Request: #2002
lanza added a commit that referenced this pull request Nov 26, 2025
@lanza
[CIR] Fix RTTI mangling assertion with qualified types
6444a40 
Fixes an assertion failure when creating RTTI descriptors for types with top-level qualifiers (const, volatile, etc.). The Itanium C++ ABI requires that RTTI descriptors be created for unqualified types only, but ClangIR was passing qualified types to the mangling function. The fix strips qualifiers in BuildTypeInfo before mangling, matching the behavior of traditional CodeGen. Also strips qualifiers when getting RTTI descriptors for dynamic_cast operands, consistent with CodeGen's implementation. This fixes std::regex usage and other cases where qualified types are used with typeid or dynamic_cast. ghstack-source-id: e18ff76 Pull-Request: #2002
lanza added a commit that referenced this pull request Nov 26, 2025
@lanza
[CIR] Fix RTTI mangling assertion with qualified types
df9fe73 
Fixes an assertion failure when creating RTTI descriptors for types with top-level qualifiers (const, volatile, etc.). The Itanium C++ ABI requires that RTTI descriptors be created for unqualified types only, but ClangIR was passing qualified types to the mangling function. The fix strips qualifiers in BuildTypeInfo before mangling, matching the behavior of traditional CodeGen. Also strips qualifiers when getting RTTI descriptors for dynamic_cast operands, consistent with CodeGen's implementation. This fixes std::regex usage and other cases where qualified types are used with typeid or dynamic_cast. ghstack-source-id: e18ff76 Pull-Request: #2002
lanza added a commit that referenced this pull request Nov 26, 2025
@lanza
[CIR] Fix RTTI mangling assertion with qualified types
64e3667 
Fixes an assertion failure when creating RTTI descriptors for types with top-level qualifiers (const, volatile, etc.). The Itanium C++ ABI requires that RTTI descriptors be created for unqualified types only, but ClangIR was passing qualified types to the mangling function. The fix strips qualifiers in BuildTypeInfo before mangling, matching the behavior of traditional CodeGen. Also strips qualifiers when getting RTTI descriptors for dynamic_cast operands, consistent with CodeGen's implementation. This fixes std::regex usage and other cases where qualified types are used with typeid or dynamic_cast. ghstack-source-id: e18ff76 Pull-Request: #2002
lanza added a commit that referenced this pull request Nov 26, 2025
@lanza
[CIR] Fix RTTI mangling assertion with qualified types
bd28926 
Fixes an assertion failure when creating RTTI descriptors for types with top-level qualifiers (const, volatile, etc.). The Itanium C++ ABI requires that RTTI descriptors be created for unqualified types only, but ClangIR was passing qualified types to the mangling function. The fix strips qualifiers in BuildTypeInfo before mangling, matching the behavior of traditional CodeGen. Also strips qualifiers when getting RTTI descriptors for dynamic_cast operands, consistent with CodeGen's implementation. This fixes std::regex usage and other cases where qualified types are used with typeid or dynamic_cast. ghstack-source-id: e18ff76 Pull-Request: #2002
lanza added a commit that referenced this pull request Nov 27, 2025
@lanza
[CIR] Fix RTTI mangling assertion with qualified types
1eb65a6 
Fixes an assertion failure when creating RTTI descriptors for types with top-level qualifiers (const, volatile, etc.). The Itanium C++ ABI requires that RTTI descriptors be created for unqualified types only, but ClangIR was passing qualified types to the mangling function. The fix strips qualifiers in BuildTypeInfo before mangling, matching the behavior of traditional CodeGen. Also strips qualifiers when getting RTTI descriptors for dynamic_cast operands, consistent with CodeGen's implementation. This fixes std::regex usage and other cases where qualified types are used with typeid or dynamic_cast. ghstack-source-id: e18ff76 Pull-Request: #2002
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@lanza