[clang-tidy] Fix modernize-use-integer-sign-comparison comparison

- add ``ConsideringIntegerSize`` option, that ignores a comparison between a signed wide and an unsigned narrow integer types, add documentation.

Author: qt-tatiana

clang-tools-extra/clang-tidy/modernize/ModernizeTidyModule.cpp

@@ -126,6 +126,14 @@ class ModernizeModule : public ClangTidyModule {
  "modernize-use-uncaught-exceptions");
  CheckFactories.registerCheck<UseUsingCheck>("modernize-use-using");
  }
+
+ ClangTidyOptions getModuleOptions() override {
+ ClangTidyOptions Options;
+ Options.CheckOptions
+ ["modernize-use-integer-sign-comparison.ConsideringIntegerSize"] =
+ "true";
+ return Options;
+ }
 };
 
 // Register the ModernizeTidyModule using this statically initialized variable.

clang-tools-extra/clang-tidy/modernize/UseIntegerSignComparisonCheck.cpp

@@ -80,11 +80,13 @@ UseIntegerSignComparisonCheck::UseIntegerSignComparisonCheck(
  : ClangTidyCheck(Name, Context),
  IncludeInserter(Options.getLocalOrGlobal("IncludeStyle",
  utils::IncludeSorter::IS_LLVM),
- areDiagsSelfContained()) {}
+ areDiagsSelfContained()),
+ ConsideringIntSize(Options.get("ConsideringIntegerSize", true)) {}
 
 void UseIntegerSignComparisonCheck::storeOptions(
  ClangTidyOptions::OptionMap &Opts) {
  Options.store(Opts, "IncludeStyle", IncludeInserter.getStyle());
+ Options.store(Opts, "ConsideringIntegerSize", ConsideringIntSize);
 }
 
 void UseIntegerSignComparisonCheck::registerMatchers(MatchFinder *Finder) {
@@ -139,10 +141,11 @@ void UseIntegerSignComparisonCheck::check(
  if (LHS == nullptr || RHS == nullptr)
  return;
 
- if (Result.Context->getTypeSize(
- SignedCastExpression->getSubExpr()->getType()) >
- Result.Context->getTypeSize(
- UnSignedCastExpression->getSubExpr()->getType()))
+ if (ConsideringIntSize &&
+ (Result.Context->getTypeSize(
+ SignedCastExpression->getSubExpr()->getType()) >
+ Result.Context->getTypeSize(
+ UnSignedCastExpression->getSubExpr()->getType())))
  return;
 
  const Expr *SubExprLHS = nullptr;

clang-tools-extra/clang-tidy/modernize/UseIntegerSignComparisonCheck.h

@@ -35,6 +35,7 @@ class UseIntegerSignComparisonCheck : public ClangTidyCheck {
 
 private:
  utils::IncludeInserter IncludeInserter;
+ const bool ConsideringIntSize;
 };
 
 } // namespace clang::tidy::modernize

clang-tools-extra/docs/ReleaseNotes.rst

@@ -301,6 +301,11 @@ Changes in existing checks
  <clang-tidy/checks/modernize/use-designated-initializers>` check to fix a
  crash when a class is declared but not defined.
 
+- Improved :doc:`modernize-use-integer-sign-comparison
+ <clang-tidy/checks/modernize/use-integer-sign-comparison>` check to
+ add an option ``ConsideringIntegerSize``, that ignores a comparison between
+ a signed wide and an unsigned narrow integer types.
+
 - Improved :doc:`modernize-use-nullptr
  <clang-tidy/checks/modernize/use-nullptr>` check to also recognize
  ``NULL``/``__null`` (but not ``0``) when used with a templated type.

clang-tools-extra/docs/clang-tidy/checks/modernize/use-integer-sign-comparison.rst

@@ -34,3 +34,7 @@ Options
 
  A string specifying which include-style is used, `llvm` or `google`.
  Default is `llvm`.
+
+.. option:: ConsideringIntegerSize
+ Ignores a comparison between a signed wide and an unsigned narrow
+ integer types. Default is `true`.