Remove unnecessary ternary in GetSourceindex

Author: chaitanyav

clang/lib/AST/ByteCode/InterpBuiltin.cpp

@@ -4467,7 +4467,7 @@ bool InterpretBuiltin(InterpState &S, CodePtr OpPC, const CallExpr *Call,
  return interp__builtin_ia32_shuffle_generic(
  S, OpPC, Call, [](unsigned DstIdx, unsigned ShuffleMask) {
  int Offset = ShuffleMask & 0x1;
- unsigned SrcIdx = (ShuffleMask >> 1) & 0x1 ? 1 : 0;
+ unsigned SrcIdx = (ShuffleMask >> 1) & 0x1;
  return std::pair<unsigned, int>{SrcIdx, Offset};
  });
  case X86::BI__builtin_ia32_vpermi2vard128:
@@ -4477,7 +4477,7 @@ bool InterpretBuiltin(InterpState &S, CodePtr OpPC, const CallExpr *Call,
  return interp__builtin_ia32_shuffle_generic(
  S, OpPC, Call, [](unsigned DstIdx, unsigned ShuffleMask) {
  int Offset = ShuffleMask & 0x3;
- unsigned SrcIdx = (ShuffleMask >> 2) & 0x1 ? 1 : 0;
+ unsigned SrcIdx = (ShuffleMask >> 2) & 0x1;
  return std::pair<unsigned, int>{SrcIdx, Offset};
  });
  case X86::BI__builtin_ia32_vpermi2varhi128:
@@ -4488,7 +4488,7 @@ bool InterpretBuiltin(InterpState &S, CodePtr OpPC, const CallExpr *Call,
  return interp__builtin_ia32_shuffle_generic(
  S, OpPC, Call, [](unsigned DstIdx, unsigned ShuffleMask) {
  int Offset = ShuffleMask & 0x7;
- unsigned SrcIdx = (ShuffleMask >> 3) & 0x1 ? 1 : 0;
+ unsigned SrcIdx = (ShuffleMask >> 3) & 0x1;
  return std::pair<unsigned, int>{SrcIdx, Offset};
  });
  case X86::BI__builtin_ia32_vpermi2varqi128:
@@ -4498,22 +4498,22 @@ bool InterpretBuiltin(InterpState &S, CodePtr OpPC, const CallExpr *Call,
  return interp__builtin_ia32_shuffle_generic(
  S, OpPC, Call, [](unsigned DstIdx, unsigned ShuffleMask) {
  int Offset = ShuffleMask & 0xF;
- unsigned SrcIdx = (ShuffleMask >> 4) & 0x1 ? 1 : 0;
+ unsigned SrcIdx = (ShuffleMask >> 4) & 0x1;
  return std::pair<unsigned, int>{SrcIdx, Offset};
  });
  case X86::BI__builtin_ia32_vpermi2varqi256:
  case X86::BI__builtin_ia32_vpermi2varhi512:
  return interp__builtin_ia32_shuffle_generic(
  S, OpPC, Call, [](unsigned DstIdx, unsigned ShuffleMask) {
  int Offset = ShuffleMask & 0x1F;
- unsigned SrcIdx = (ShuffleMask >> 5) & 0x1 ? 1 : 0;
+ unsigned SrcIdx = (ShuffleMask >> 5) & 0x1;
  return std::pair<unsigned, int>{SrcIdx, Offset};
  });
  case X86::BI__builtin_ia32_vpermi2varqi512:
  return interp__builtin_ia32_shuffle_generic(
  S, OpPC, Call, [](unsigned DstIdx, unsigned ShuffleMask) {
  int Offset = ShuffleMask & 0x3F;
- unsigned SrcIdx = (ShuffleMask >> 6) & 0x1 ? 1 : 0;
+ unsigned SrcIdx = (ShuffleMask >> 6) & 0x1;
  return std::pair<unsigned, int>{SrcIdx, Offset};
  });
  case X86::BI__builtin_ia32_pshufb128:

clang/lib/AST/ExprConstant.cpp

@@ -13103,7 +13103,7 @@ bool VectorExprEvaluator::VisitCallExpr(const CallExpr *E) {
  if (!evalShuffleGeneric(
  Info, E, R, [](unsigned DstIdx, unsigned ShuffleMask) {
  int Offset = ShuffleMask & 0x1;
- unsigned SrcIdx = (ShuffleMask >> 1) & 0x1 ? 1 : 0;
+ unsigned SrcIdx = (ShuffleMask >> 1) & 0x1;
  return std::pair<unsigned, int>{SrcIdx, Offset};
  }))
  return false;
@@ -13117,7 +13117,7 @@ bool VectorExprEvaluator::VisitCallExpr(const CallExpr *E) {
  if (!evalShuffleGeneric(
  Info, E, R, [](unsigned DstIdx, unsigned ShuffleMask) {
  int Offset = ShuffleMask & 0x3;
- unsigned SrcIdx = (ShuffleMask >> 2) & 0x1 ? 1 : 0;
+ unsigned SrcIdx = (ShuffleMask >> 2) & 0x1;
  return std::pair<unsigned, int>{SrcIdx, Offset};
  }))
  return false;
@@ -13132,7 +13132,7 @@ bool VectorExprEvaluator::VisitCallExpr(const CallExpr *E) {
  if (!evalShuffleGeneric(
  Info, E, R, [](unsigned DstIdx, unsigned ShuffleMask) {
  int Offset = ShuffleMask & 0x7;
- unsigned SrcIdx = (ShuffleMask >> 3) & 0x1 ? 1 : 0;
+ unsigned SrcIdx = (ShuffleMask >> 3) & 0x1;
  return std::pair<unsigned, int>{SrcIdx, Offset};
  }))
  return false;
@@ -13146,7 +13146,7 @@ bool VectorExprEvaluator::VisitCallExpr(const CallExpr *E) {
  if (!evalShuffleGeneric(
  Info, E, R, [](unsigned DstIdx, unsigned ShuffleMask) {
  int Offset = ShuffleMask & 0xF;
- unsigned SrcIdx = (ShuffleMask >> 4) & 0x1 ? 1 : 0;
+ unsigned SrcIdx = (ShuffleMask >> 4) & 0x1;
  return std::pair<unsigned, int>{SrcIdx, Offset};
  }))
  return false;
@@ -13158,7 +13158,7 @@ bool VectorExprEvaluator::VisitCallExpr(const CallExpr *E) {
  if (!evalShuffleGeneric(
  Info, E, R, [](unsigned DstIdx, unsigned ShuffleMask) {
  int Offset = ShuffleMask & 0x1F;
- unsigned SrcIdx = (ShuffleMask >> 5) & 0x1 ? 1 : 0;
+ unsigned SrcIdx = (ShuffleMask >> 5) & 0x1;
  return std::pair<unsigned, int>{SrcIdx, Offset};
  }))
  return false;
@@ -13169,7 +13169,7 @@ bool VectorExprEvaluator::VisitCallExpr(const CallExpr *E) {
  if (!evalShuffleGeneric(
  Info, E, R, [](unsigned DstIdx, unsigned ShuffleMask) {
  int Offset = ShuffleMask & 0x3F;
- unsigned SrcIdx = (ShuffleMask >> 6) & 0x1 ? 1 : 0;
+ unsigned SrcIdx = (ShuffleMask >> 6) & 0x1;
  return std::pair<unsigned, int>{SrcIdx, Offset};
  }))
  return false;