address comments

Author: matthias-springer

mlir/lib/Conversion/ArithToAPFloat/ArithToAPFloat.cpp

@@ -159,9 +159,8 @@ struct FpToFpConversion final : OpRewritePattern<OpTy> {
  Location loc = op.getLoc();
  auto inFloatTy = cast<FloatType>(op.getOperand().getType());
  auto inIntWType = rewriter.getIntegerType(inFloatTy.getWidth());
- auto int64Type = rewriter.getI64Type();
  Value operandBits = arith::ExtUIOp::create(
- rewriter, loc, int64Type,
+ rewriter, loc, i64Type,
  arith::BitcastOp::create(rewriter, loc, inIntWType, op.getOperand()));
 
  // Call APFloat function.
@@ -194,6 +193,10 @@ struct FpToIntConversion final : OpRewritePattern<OpTy> {
 
  LogicalResult matchAndRewrite(OpTy op,
  PatternRewriter &rewriter) const override {
+ if (op.getType().getIntOrFloatBitWidth() > 64)
+ return rewriter.notifyMatchFailure(
+ op, "result type > 64 bits is not supported");
+
  // Get APFloat function from runtime library.
  auto i1Type = IntegerType::get(symTable->getContext(), 1);
  auto i32Type = IntegerType::get(symTable->getContext(), 32);
@@ -209,9 +212,8 @@ struct FpToIntConversion final : OpRewritePattern<OpTy> {
  Location loc = op.getLoc();
  auto inFloatTy = cast<FloatType>(op.getOperand().getType());
  auto inIntWType = rewriter.getIntegerType(inFloatTy.getWidth());
- auto int64Type = rewriter.getI64Type();
  Value operandBits = arith::ExtUIOp::create(
- rewriter, loc, int64Type,
+ rewriter, loc, i64Type,
  arith::BitcastOp::create(rewriter, loc, inIntWType, op.getOperand()));
 
  // Call APFloat function.

mlir/lib/ExecutionEngine/APFloatWrappers.cpp

@@ -113,6 +113,10 @@ MLIR_APFLOAT_WRAPPERS_EXPORT uint64_t _mlir_apfloat_convert_to_int(
  bool isExact;
  // TODO: Custom rounding modes are not supported yet.
  val.convertToInteger(result, llvm::RoundingMode::NearestTiesToEven, &isExact);
+ // This function always returns uint64_t, regardless of the desired result
+ // width. It does not matter whether we zero-extend or sign-extend the APSInt
+ // to 64 bits because the generated IR in arith-to-apfloat will truncate the
+ // result to the desired result width.
  return result.getZExtValue();
 }
 }