[ADT] Rename llvm::erase_value to llvm::erase (NFC) (#70156)

C++20 comes with std::erase to erase a value from std::vector. This patch renames llvm::erase_value to llvm::erase for consistency with C++20. We could make llvm::erase more similar to std::erase by having it return the number of elements removed, but I'm not doing that for now because nobody seems to care about that in our code base. Since there are only 50 occurrences of erase_value in our code base, this patch replaces all of them with llvm::erase and deprecates llvm::erase_value.

Author: kazutakahirata

bolt/lib/Passes/HFSortPlus.cpp

@@ -567,7 +567,7 @@ class HFSortPlus {
  Into->Score = score(Into);
 
  // Remove chain From From the list of active chains
- llvm::erase_value(HotChains, From);
+ llvm::erase(HotChains, From);
  }
 
 private:

bolt/lib/Passes/IndirectCallPromotion.cpp

@@ -591,7 +591,7 @@ IndirectCallPromotion::findCallTargetSymbols(std::vector<Callsite> &Targets,
 
  NewTargets.push_back(Target);
  std::vector<uint64_t>({JTIndex}).swap(NewTargets.back().JTIndices);
- llvm::erase_value(Target.JTIndices, JTIndex);
+ llvm::erase(Target.JTIndices, JTIndex);
 
  // Keep fixCFG counts sane if more indices use this same target later
  assert(IndicesPerTarget[Target.To.Sym] > 0 && "wrong map");

clang-tools-extra/clangd/FindTarget.cpp

@@ -1131,7 +1131,7 @@ class ExplicitReferenceCollector
  void reportReference(ReferenceLoc &&Ref, DynTypedNode N) {
  // Strip null targets that can arise from invalid code.
  // (This avoids having to check for null everywhere we insert)
- llvm::erase_value(Ref.Targets, nullptr);
+ llvm::erase(Ref.Targets, nullptr);
  // Our promise is to return only references from the source code. If we lack
  // location information, skip these nodes.
  // Normally this should not happen in practice, unless there are bugs in the

clang-tools-extra/clangd/SystemIncludeExtractor.cpp

@@ -389,7 +389,7 @@ extractSystemIncludesAndTarget(const DriverArgs &InputArgs,
  auto Path = llvm::StringRef(*BuiltinHeaders).trim();
  if (!Path.empty() && llvm::sys::path::is_absolute(Path)) {
  auto Size = Info->SystemIncludes.size();
- llvm::erase_value(Info->SystemIncludes, Path);
+ llvm::erase(Info->SystemIncludes, Path);
  vlog("System includes extractor: builtin headers {0} {1}", Path,
  (Info->SystemIncludes.size() != Size)
  ? "excluded"

clang/include/clang/Analysis/Analyses/Dominators.h

@@ -202,7 +202,7 @@ struct ChildrenGetterTy<clang::CFGBlock, IsPostDom> {
 
  auto Children = children<OrderedNodeTy>(N);
  ChildrenTy Ret{Children.begin(), Children.end()};
- llvm::erase_value(Ret, nullptr);
+ llvm::erase(Ret, nullptr);
  return Ret;
  }
 };

clang/include/clang/Basic/JsonSupport.h

@@ -71,7 +71,7 @@ inline std::string JsonFormat(StringRef RawSR, bool AddQuotes) {
  }
 
  // Remove new-lines.
- llvm::erase_value(Str, '\n');
+ llvm::erase(Str, '\n');
 
  if (!AddQuotes)
  return Str;

clang/include/clang/Sema/ScopeInfo.h

@@ -1027,7 +1027,7 @@ class LambdaScopeInfo final :
  return NonODRUsedCapturingExprs.count(CapturingVarExpr);
  }
  void removePotentialCapture(Expr *E) {
- llvm::erase_value(PotentiallyCapturingExprs, E);
+ llvm::erase(PotentiallyCapturingExprs, E);
  }
  void clearPotentialCaptures() {
  PotentiallyCapturingExprs.clear();

clang/lib/AST/ASTContext.cpp

@@ -1081,7 +1081,7 @@ void ASTContext::deduplicateMergedDefinitonsFor(NamedDecl *ND) {
  for (Module *&M : Merged)
  if (!Found.insert(M).second)
  M = nullptr;
- llvm::erase_value(Merged, nullptr);
+ llvm::erase(Merged, nullptr);
 }
 
 ArrayRef<Module *>

clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp

@@ -307,7 +307,7 @@ computeBlockInputState(const CFGBlock &Block, AnalysisContext &AC) {
  auto &StmtToBlock = AC.CFCtx.getStmtToBlock();
  auto StmtBlock = StmtToBlock.find(Block.getTerminatorStmt());
  assert(StmtBlock != StmtToBlock.end());
- llvm::erase_value(Preds, StmtBlock->getSecond());
+ llvm::erase(Preds, StmtBlock->getSecond());
  }
  }
 

clang/lib/Sema/SemaExpr.cpp

@@ -18303,7 +18303,7 @@ void Sema::CheckUnusedVolatileAssignment(Expr *E) {
  if (auto *BO = dyn_cast<BinaryOperator>(E->IgnoreParenImpCasts())) {
  if (BO->getOpcode() == BO_Assign) {
  auto &LHSs = ExprEvalContexts.back().VolatileAssignmentLHSs;
- llvm::erase_value(LHSs, BO->getLHS());
+ llvm::erase(LHSs, BO->getLHS());
  }
  }
 }