- Notifications
You must be signed in to change notification settings - Fork 15.3k
Closed
Closed
Copy link
Labels
backend:X86code-qualitygood first issuehttps://github.com/llvm/llvm-project/contributehttps://github.com/llvm/llvm-project/contribute
Description
Static analyser cppcheck says:
llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:3804:47: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
Source code is
for (unsigned i = TSFlags & X86II::EVEX_K ? 2 : 1; I am guessing that
for (unsigned i = (TSFlags & X86II::EVEX_K) ? 2 : 1; was intended. Suggest add () for clarity of intention.
Not all of us know all the C precedence rules well.
Metadata
Metadata
Assignees
Labels
backend:X86code-qualitygood first issuehttps://github.com/llvm/llvm-project/contributehttps://github.com/llvm/llvm-project/contribute