- Notifications
You must be signed in to change notification settings - Fork 15.3k
Closed
Labels
Description
From #66462 (review), it shows that now clangDependencyScanning depends on clangCodeGen, which cause the size of clangd to be much larger.
I found the reason why clangDependencyScanning depends on clangCodeGen is that DependencyScanningWorker.cpp uses ObjectFilePCHContainerReader:
llvm-project/clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp
Lines 489 to 490 in b634e05
| PCHContainerOps->registerReader( | |
| std::make_unique<ObjectFilePCHContainerReader>()); |
It looks odd that clangDependencyScanning depends on clangCodeGen. Is there any chance to get rid of that?