Skip to content

Conversation

@kazutakahirata
Copy link
Contributor

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Oct 23, 2024

@llvm/pr-subscribers-backend-amdgpu

Author: Kazu Hirata (kazutakahirata)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/113409.diff

1 Files Affected:

  • (modified) llvm/lib/Target/AMDGPU/AMDGPULateCodeGenPrepare.cpp (+2-2)
diff --git a/llvm/lib/Target/AMDGPU/AMDGPULateCodeGenPrepare.cpp b/llvm/lib/Target/AMDGPU/AMDGPULateCodeGenPrepare.cpp index 77350dbb6167cb..c80d60c3a52112 100644 --- a/llvm/lib/Target/AMDGPU/AMDGPULateCodeGenPrepare.cpp +++ b/llvm/lib/Target/AMDGPU/AMDGPULateCodeGenPrepare.cpp @@ -329,8 +329,8 @@ bool LiveRegOptimizer::optimizeLiveType( Type *NewType = calculateConvertType(Phi->getType()); NewPhi->addIncoming(ConstantInt::get(NewType, 0, false), Phi->getIncomingBlock(I)); - } else if (ValMap.contains(IncVal) && ValMap[IncVal]) - NewPhi->addIncoming(ValMap[IncVal], Phi->getIncomingBlock(I)); + } else if (Value *Val = ValMap.lookup(IncVal)) + NewPhi->addIncoming(Val, Phi->getIncomingBlock(I)); else MissingIncVal = true; } 
@kazutakahirata kazutakahirata merged commit 0cb80c4 into llvm:main Oct 23, 2024
10 checks passed
@kazutakahirata kazutakahirata deleted the cleanup_001_repeated_hash_lookups_AMDGPU branch October 23, 2024 06:02
@frobtech frobtech mentioned this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants