[libc] Pass through LIBC_CONF_MATH_OPTIMIZATIONS correctly #113540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
It's checked in a cmake function that builds up a list called `config_options`. But the check was appending to a list called `compile_options`, so the intended `-DLIBC_MATH=whatever` didn't end up on the actual compile command lines.
Member
| @llvm/pr-subscribers-libc Author: Simon Tatham (statham-arm) ChangesIt's checked in a cmake function that builds up a list called Full diff: https://github.com/llvm/llvm-project/pull/113540.diff 1 Files Affected:
diff --git a/libc/cmake/modules/LLVMLibCCompileOptionRules.cmake b/libc/cmake/modules/LLVMLibCCompileOptionRules.cmake index 0c658c6866c437..e30f7d322eb029 100644 --- a/libc/cmake/modules/LLVMLibCCompileOptionRules.cmake +++ b/libc/cmake/modules/LLVMLibCCompileOptionRules.cmake @@ -84,7 +84,7 @@ function(_get_compile_options_from_config output_var) endif() if(LIBC_CONF_MATH_OPTIMIZATIONS) - list(APPEND compile_options "-DLIBC_MATH=${LIBC_CONF_MATH_OPTIMIZATIONS}") + list(APPEND config_options "-DLIBC_MATH=${LIBC_CONF_MATH_OPTIMIZATIONS}") endif() set(${output_var} ${config_options} PARENT_SCOPE) |
lntue approved these changes Oct 24, 2024
Closed
NoumanAmir657 pushed a commit to NoumanAmir657/llvm-project that referenced this pull request Nov 4, 2024
It's checked in a cmake function that builds up a list called `config_options`. But the check was appending to a list called `compile_options`, so the intended `-DLIBC_MATH=whatever` didn't end up on the actual compile command lines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
It's checked in a cmake function that builds up a list called
config_options. But the check was appending to a list calledcompile_options, so the intended-DLIBC_MATH=whateverdidn't end up on the actual compile command lines.