[DebugInfo] Correct an overly-restrictive REQUIRES clause.

[CarlosAlbertoEnciso]

Include a regular expression in the 'REQUIRES' clause, to run
the test on all matching targets (x86_64 linux).

The original patch restricted to test just to 'x86_64-linux'
#116327

[llvmbot]

@llvm/pr-subscribers-debuginfo

Author: Carlos Alberto Enciso (CarlosAlbertoEnciso)

Changes

…. (#116327)

Consider the case when the compiler generates a static member. Any consumer of the debug info generated for that case, would benefit if that member has the DW_AT_artificial flag.

Fix the syntax for 'REQUIRES', to include a regular expression.

---

Full diff: https://github.com/llvm/llvm-project/pull/116429.diff

1 Files Affected:

• (modified) llvm/test/DebugInfo/Generic/artificial-static-member.ll (+1-1)

diff --git a/llvm/test/DebugInfo/Generic/artificial-static-member.ll b/llvm/test/DebugInfo/Generic/artificial-static-member.ll index 5c247d6959bf7b..47b7fa33b686f4 100644 --- a/llvm/test/DebugInfo/Generic/artificial-static-member.ll +++ b/llvm/test/DebugInfo/Generic/artificial-static-member.ll @@ -1,4 +1,4 @@ -; REQUIRES: x86_64-linux +; REQUIRES: target={{x86_64-.*-linux}} ; RUN: llc -O0 -filetype=obj < %s | \ ; RUN: llvm-dwarfdump --debug-info - | FileCheck %s 

[jmorse]

LGTM, but you should write the commit message to be directly about what you're changing here, not carry with it the context of what the original patch did. Someone viewing this in isolation could be confused by that -- better to instead title it "Correct an overly-restrictive REQUIRES clause", another sentence of explanation, and then a link back to the original patch this landed in in case someone wants to read up on it.

[CarlosAlbertoEnciso]

@jmorse, @dwblaikie Thanks for your feedback.
Looking into more detail, the regular expression should be: {{x86_64-.*-linux.*}}
Updated title and commit comment to include link to original patch.