Skip to content

Conversation

@DhruvSrivastavaX
Copy link
Member

This PR is in reference to porting LLDB on AIX.

Link to discussions on llvm discourse and github:

  1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
  2. Extending LLDB to work on AIX #101657
    The complete changes for porting are present in this draft PR:
    Extending LLDB to work on AIX #102601

Added clang-format changes for ProcessLauncherPosixFork.cpp which will be followed by ptrace changes in:

Review Request: @DavidSpickett

@llvmbot
Copy link
Member

llvmbot commented Dec 18, 2024

@llvm/pr-subscribers-lldb

Author: Dhruv Srivastava (DhruvSrivastavaX)

Changes

This PR is in reference to porting LLDB on AIX.

Link to discussions on llvm discourse and github:

  1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
  2. Extending LLDB to work on AIX #101657
    The complete changes for porting are present in this draft PR:
    Extending LLDB to work on AIX #102601

Added clang-format changes for ProcessLauncherPosixFork.cpp which will be followed by ptrace changes in:

Review Request: @DavidSpickett


Full diff: https://github.com/llvm/llvm-project/pull/120459.diff

1 Files Affected:

  • (modified) lldb/source/Host/posix/ProcessLauncherPosixFork.cpp (+2-3)
diff --git a/lldb/source/Host/posix/ProcessLauncherPosixFork.cpp b/lldb/source/Host/posix/ProcessLauncherPosixFork.cpp index 4a9469bde2f186..4a0437b634ee39 100644 --- a/lldb/source/Host/posix/ProcessLauncherPosixFork.cpp +++ b/lldb/source/Host/posix/ProcessLauncherPosixFork.cpp @@ -21,8 +21,8 @@ #include <sys/wait.h> #include <unistd.h> -#include <sstream> #include <csignal> +#include <sstream> #ifdef __ANDROID__ #include <android/api-level.h> @@ -47,8 +47,7 @@ static void write_string(int error_fd, const char *str) { (void)r; } -[[noreturn]] static void ExitWithError(int error_fd, - const char *operation) { +[[noreturn]] static void ExitWithError(int error_fd, const char *operation) { int err = errno; write_string(error_fd, operation); write_string(error_fd, " failed: "); 
@DavidSpickett DavidSpickett merged commit 2210da3 into llvm:main Dec 19, 2024
9 checks passed
@DavidSpickett
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants