[lit] Add HOME to "safe" variables to pass through to tests #139367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Incldue `HOME` among the variables that are passed through to tests when environment is cleaned. This is necessary for Gentoo build environments, where individual package builds are given temporary home directories that are exposed via `HOME` variable. By stripping the variable, `lit` made these tests attempt to access user's home directory, resulting in permission errors.
Member
| @llvm/pr-subscribers-testing-tools Author: Michał Górny (mgorny) ChangesIncldue Full diff: https://github.com/llvm/llvm-project/pull/139367.diff 1 Files Affected:
diff --git a/llvm/utils/lit/lit/TestingConfig.py b/llvm/utils/lit/lit/TestingConfig.py index b0d8e7149e553..c063851b89526 100644 --- a/llvm/utils/lit/lit/TestingConfig.py +++ b/llvm/utils/lit/lit/TestingConfig.py @@ -66,6 +66,7 @@ def fromdefaults(litConfig): "DFLTCC", "QEMU_LD_PREFIX", "QEMU_CPU", + "HOME", ] if sys.platform.startswith("aix"): |
thesamesam approved these changes May 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Incldue
HOMEamong the variables that are passed through to tests when environment is cleaned. This is necessary for Gentoo build environments, where individual package builds are given temporary home directories that are exposed viaHOMEvariable. By stripping the variable,litmade these tests attempt to access user's home directory, resulting in permission errors.