[lldb-dap] Add missing key for capabilities event. #142751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
fixes the failed tests on arch64. complements llvm#142439
Member
| @llvm/pr-subscribers-lldb Author: Ebuka Ezike (da-viper) Changesfixes the failed tests on arch64. complements #142439 Full diff: https://github.com/llvm/llvm-project/pull/142751.diff 1 Files Affected:
diff --git a/lldb/tools/lldb-dap/EventHelper.cpp b/lldb/tools/lldb-dap/EventHelper.cpp index 0dd0b61b1e2ae..33bc7c2cbef11 100644 --- a/lldb/tools/lldb-dap/EventHelper.cpp +++ b/lldb/tools/lldb-dap/EventHelper.cpp @@ -46,7 +46,9 @@ void SendTargetBasedCapabilities(DAP &dap) { protocol::Event event; event.event = "capabilities"; - event.body = llvm::json::Object{{"supportsStepInTargetsRequest", false}}; + event.body = llvm::json::Object{ + {"capabilities", + llvm::json::Object{{"supportsStepInTargetsRequest", false}}}}; dap.Send(event); } // "ProcessEvent": { |
DavidSpickett approved these changes Jun 4, 2025
JDevlieghere added a commit to JDevlieghere/llvm-project that referenced this pull request Jun 5, 2025
…)" This reverts commit 159de36.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fixes the failed tests on aarch64.
complements #142439