Revert "[MemProf] Drop unneccessary REQUIRES: x86-linux directives." #142816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| @llvm/pr-subscribers-pgo Author: Snehasish Kumar (snehasish) ChangesReverts llvm/llvm-project#142718 Breaks ppc aix builds: https://lab.llvm.org/buildbot/#/builders/64/builds/4036 Full diff: https://github.com/llvm/llvm-project/pull/142816.diff 9 Files Affected:
diff --git a/llvm/test/Transforms/PGOProfile/memprof-call-site-at-alloc-site.ll b/llvm/test/Transforms/PGOProfile/memprof-call-site-at-alloc-site.ll index a0a359cea6a36..b5a4648dad74d 100644 --- a/llvm/test/Transforms/PGOProfile/memprof-call-site-at-alloc-site.ll +++ b/llvm/test/Transforms/PGOProfile/memprof-call-site-at-alloc-site.ll @@ -2,6 +2,7 @@ ; allocation call stack but does not call one of the memory allocation ; functions. +; REQUIRES: x86_64-linux ; RUN: split-file %s %t ; RUN: llvm-profdata merge %t/memprof-call-site-at-alloc-site.yaml -o %t/memprof-call-site-at-alloc-site.memprofdata ; RUN: opt < %t/memprof-call-site-at-alloc-site.ll -passes='memprof-use<profile-filename=%t/memprof-call-site-at-alloc-site.memprofdata>' -memprof-print-match-info -S 2>&1 | FileCheck %s diff --git a/llvm/test/Transforms/PGOProfile/memprof-dump-matched-alloc-site.ll b/llvm/test/Transforms/PGOProfile/memprof-dump-matched-alloc-site.ll index 993cc42ff41a3..2dcaa9d492869 100644 --- a/llvm/test/Transforms/PGOProfile/memprof-dump-matched-alloc-site.ll +++ b/llvm/test/Transforms/PGOProfile/memprof-dump-matched-alloc-site.ll @@ -23,6 +23,7 @@ ; ; Here we expect to match the allocation site to encompass 3 frames. +; REQUIRES: x86_64-linux ; RUN: split-file %s %t ; RUN: llvm-profdata merge %t/memprof-dump-matched-alloc-site.yaml -o %t/memprof-dump-matched-alloc-site.memprofdata ; RUN: opt < %t/memprof-dump-matched-alloc-site.ll -passes='memprof-use<profile-filename=%t/memprof-dump-matched-alloc-site.memprofdata>' -memprof-print-match-info -S 2>&1 | FileCheck %s diff --git a/llvm/test/Transforms/PGOProfile/memprof-dump-matched-call-sites.ll b/llvm/test/Transforms/PGOProfile/memprof-dump-matched-call-sites.ll index ed3a079a93f73..fa99116b820f9 100644 --- a/llvm/test/Transforms/PGOProfile/memprof-dump-matched-call-sites.ll +++ b/llvm/test/Transforms/PGOProfile/memprof-dump-matched-call-sites.ll @@ -31,6 +31,7 @@ ; Note that f3 is considered to be an allocation site, not a call site, because ; it directly calls new after inlining. +; REQUIRES: x86_64-linux ; RUN: split-file %s %t ; RUN: llvm-profdata merge %t/memprof-dump-matched-call-site.yaml -o %t/memprof-dump-matched-call-site.memprofdata ; RUN: opt < %t/memprof-dump-matched-call-site.ll -passes='memprof-use<profile-filename=%t/memprof-dump-matched-call-site.memprofdata>' -memprof-print-match-info -S 2>&1 | FileCheck %s diff --git a/llvm/test/Transforms/PGOProfile/memprof-undrift.test b/llvm/test/Transforms/PGOProfile/memprof-undrift.test index b2006fa3f8bf8..5529c7701f6ec 100644 --- a/llvm/test/Transforms/PGOProfile/memprof-undrift.test +++ b/llvm/test/Transforms/PGOProfile/memprof-undrift.test @@ -1,3 +1,4 @@ +; REQUIRES: x86_64-linux ; Make sure that we can undrift the MemProf profile and annotate the IR ; accordingly. diff --git a/llvm/test/Transforms/PGOProfile/memprof_annotate_yaml.test b/llvm/test/Transforms/PGOProfile/memprof_annotate_yaml.test index 28ded32082b19..1ef963dec9e23 100644 --- a/llvm/test/Transforms/PGOProfile/memprof_annotate_yaml.test +++ b/llvm/test/Transforms/PGOProfile/memprof_annotate_yaml.test @@ -1,3 +1,4 @@ +; REQUIRES: x86_64-linux ; Make sure that we can ingest the MemProf profile in YAML and ; annotate a call to new as cold. diff --git a/llvm/test/Transforms/PGOProfile/memprof_discard_threshold.ll b/llvm/test/Transforms/PGOProfile/memprof_discard_threshold.ll index 92a2a0ecd789d..a1f8369243888 100644 --- a/llvm/test/Transforms/PGOProfile/memprof_discard_threshold.ll +++ b/llvm/test/Transforms/PGOProfile/memprof_discard_threshold.ll @@ -1,5 +1,7 @@ ;; Tests option to discard small noncold contexts. +;; Avoid failures on big-endian systems that can't read the profile properly +; REQUIRES: x86_64-linux ;; Generate the profile and the IR. ; RUN: split-file %s %t diff --git a/llvm/test/Transforms/PGOProfile/memprof_match_hot_cold_new_calls.ll b/llvm/test/Transforms/PGOProfile/memprof_match_hot_cold_new_calls.ll index 596323c662deb..4aa0511622662 100644 --- a/llvm/test/Transforms/PGOProfile/memprof_match_hot_cold_new_calls.ll +++ b/llvm/test/Transforms/PGOProfile/memprof_match_hot_cold_new_calls.ll @@ -1,6 +1,8 @@ ;; Tests optional matching of memprof profile on call to operator new ;; with manual hot/cold hint. +;; Avoid failures on big-endian systems that can't read the profile properly +; REQUIRES: x86_64-linux ;; Generate the profile and the IR. ; RUN: split-file %s %t diff --git a/llvm/test/Transforms/PGOProfile/memprof_missing_leaf.ll b/llvm/test/Transforms/PGOProfile/memprof_missing_leaf.ll index 3c1c58d62647e..e6fb1863acbce 100644 --- a/llvm/test/Transforms/PGOProfile/memprof_missing_leaf.ll +++ b/llvm/test/Transforms/PGOProfile/memprof_missing_leaf.ll @@ -3,6 +3,8 @@ ;; matching and we are able to match the next call frame up the inlined ;; context. +;; Avoid failures on big-endian systems that can't read the profile properly +; REQUIRES: x86_64-linux ;; # To generate below LLVM IR for use in matching. ;; $ clang++ -gmlt -fdebug-info-for-profiling -S memprof_missing_leaf.cc \ diff --git a/llvm/test/tools/llvm-profdata/memprof-yaml-invalid.test b/llvm/test/tools/llvm-profdata/memprof-yaml-invalid.test index 0810bcdaa40cc..a13451cee5116 100644 --- a/llvm/test/tools/llvm-profdata/memprof-yaml-invalid.test +++ b/llvm/test/tools/llvm-profdata/memprof-yaml-invalid.test @@ -1,3 +1,4 @@ +; REQUIRES: x86_64-linux ; RUN: split-file %s %t ; RUN: not llvm-profdata merge %t/memprof-invalid.yaml -o %t/memprof-invalid.indexed |
Member
| @llvm/pr-subscribers-llvm-transforms Author: Snehasish Kumar (snehasish) ChangesReverts llvm/llvm-project#142718 Breaks ppc aix builds: https://lab.llvm.org/buildbot/#/builders/64/builds/4036 Full diff: https://github.com/llvm/llvm-project/pull/142816.diff 9 Files Affected:
diff --git a/llvm/test/Transforms/PGOProfile/memprof-call-site-at-alloc-site.ll b/llvm/test/Transforms/PGOProfile/memprof-call-site-at-alloc-site.ll index a0a359cea6a36..b5a4648dad74d 100644 --- a/llvm/test/Transforms/PGOProfile/memprof-call-site-at-alloc-site.ll +++ b/llvm/test/Transforms/PGOProfile/memprof-call-site-at-alloc-site.ll @@ -2,6 +2,7 @@ ; allocation call stack but does not call one of the memory allocation ; functions. +; REQUIRES: x86_64-linux ; RUN: split-file %s %t ; RUN: llvm-profdata merge %t/memprof-call-site-at-alloc-site.yaml -o %t/memprof-call-site-at-alloc-site.memprofdata ; RUN: opt < %t/memprof-call-site-at-alloc-site.ll -passes='memprof-use<profile-filename=%t/memprof-call-site-at-alloc-site.memprofdata>' -memprof-print-match-info -S 2>&1 | FileCheck %s diff --git a/llvm/test/Transforms/PGOProfile/memprof-dump-matched-alloc-site.ll b/llvm/test/Transforms/PGOProfile/memprof-dump-matched-alloc-site.ll index 993cc42ff41a3..2dcaa9d492869 100644 --- a/llvm/test/Transforms/PGOProfile/memprof-dump-matched-alloc-site.ll +++ b/llvm/test/Transforms/PGOProfile/memprof-dump-matched-alloc-site.ll @@ -23,6 +23,7 @@ ; ; Here we expect to match the allocation site to encompass 3 frames. +; REQUIRES: x86_64-linux ; RUN: split-file %s %t ; RUN: llvm-profdata merge %t/memprof-dump-matched-alloc-site.yaml -o %t/memprof-dump-matched-alloc-site.memprofdata ; RUN: opt < %t/memprof-dump-matched-alloc-site.ll -passes='memprof-use<profile-filename=%t/memprof-dump-matched-alloc-site.memprofdata>' -memprof-print-match-info -S 2>&1 | FileCheck %s diff --git a/llvm/test/Transforms/PGOProfile/memprof-dump-matched-call-sites.ll b/llvm/test/Transforms/PGOProfile/memprof-dump-matched-call-sites.ll index ed3a079a93f73..fa99116b820f9 100644 --- a/llvm/test/Transforms/PGOProfile/memprof-dump-matched-call-sites.ll +++ b/llvm/test/Transforms/PGOProfile/memprof-dump-matched-call-sites.ll @@ -31,6 +31,7 @@ ; Note that f3 is considered to be an allocation site, not a call site, because ; it directly calls new after inlining. +; REQUIRES: x86_64-linux ; RUN: split-file %s %t ; RUN: llvm-profdata merge %t/memprof-dump-matched-call-site.yaml -o %t/memprof-dump-matched-call-site.memprofdata ; RUN: opt < %t/memprof-dump-matched-call-site.ll -passes='memprof-use<profile-filename=%t/memprof-dump-matched-call-site.memprofdata>' -memprof-print-match-info -S 2>&1 | FileCheck %s diff --git a/llvm/test/Transforms/PGOProfile/memprof-undrift.test b/llvm/test/Transforms/PGOProfile/memprof-undrift.test index b2006fa3f8bf8..5529c7701f6ec 100644 --- a/llvm/test/Transforms/PGOProfile/memprof-undrift.test +++ b/llvm/test/Transforms/PGOProfile/memprof-undrift.test @@ -1,3 +1,4 @@ +; REQUIRES: x86_64-linux ; Make sure that we can undrift the MemProf profile and annotate the IR ; accordingly. diff --git a/llvm/test/Transforms/PGOProfile/memprof_annotate_yaml.test b/llvm/test/Transforms/PGOProfile/memprof_annotate_yaml.test index 28ded32082b19..1ef963dec9e23 100644 --- a/llvm/test/Transforms/PGOProfile/memprof_annotate_yaml.test +++ b/llvm/test/Transforms/PGOProfile/memprof_annotate_yaml.test @@ -1,3 +1,4 @@ +; REQUIRES: x86_64-linux ; Make sure that we can ingest the MemProf profile in YAML and ; annotate a call to new as cold. diff --git a/llvm/test/Transforms/PGOProfile/memprof_discard_threshold.ll b/llvm/test/Transforms/PGOProfile/memprof_discard_threshold.ll index 92a2a0ecd789d..a1f8369243888 100644 --- a/llvm/test/Transforms/PGOProfile/memprof_discard_threshold.ll +++ b/llvm/test/Transforms/PGOProfile/memprof_discard_threshold.ll @@ -1,5 +1,7 @@ ;; Tests option to discard small noncold contexts. +;; Avoid failures on big-endian systems that can't read the profile properly +; REQUIRES: x86_64-linux ;; Generate the profile and the IR. ; RUN: split-file %s %t diff --git a/llvm/test/Transforms/PGOProfile/memprof_match_hot_cold_new_calls.ll b/llvm/test/Transforms/PGOProfile/memprof_match_hot_cold_new_calls.ll index 596323c662deb..4aa0511622662 100644 --- a/llvm/test/Transforms/PGOProfile/memprof_match_hot_cold_new_calls.ll +++ b/llvm/test/Transforms/PGOProfile/memprof_match_hot_cold_new_calls.ll @@ -1,6 +1,8 @@ ;; Tests optional matching of memprof profile on call to operator new ;; with manual hot/cold hint. +;; Avoid failures on big-endian systems that can't read the profile properly +; REQUIRES: x86_64-linux ;; Generate the profile and the IR. ; RUN: split-file %s %t diff --git a/llvm/test/Transforms/PGOProfile/memprof_missing_leaf.ll b/llvm/test/Transforms/PGOProfile/memprof_missing_leaf.ll index 3c1c58d62647e..e6fb1863acbce 100644 --- a/llvm/test/Transforms/PGOProfile/memprof_missing_leaf.ll +++ b/llvm/test/Transforms/PGOProfile/memprof_missing_leaf.ll @@ -3,6 +3,8 @@ ;; matching and we are able to match the next call frame up the inlined ;; context. +;; Avoid failures on big-endian systems that can't read the profile properly +; REQUIRES: x86_64-linux ;; # To generate below LLVM IR for use in matching. ;; $ clang++ -gmlt -fdebug-info-for-profiling -S memprof_missing_leaf.cc \ diff --git a/llvm/test/tools/llvm-profdata/memprof-yaml-invalid.test b/llvm/test/tools/llvm-profdata/memprof-yaml-invalid.test index 0810bcdaa40cc..a13451cee5116 100644 --- a/llvm/test/tools/llvm-profdata/memprof-yaml-invalid.test +++ b/llvm/test/tools/llvm-profdata/memprof-yaml-invalid.test @@ -1,3 +1,4 @@ +; REQUIRES: x86_64-linux ; RUN: split-file %s %t ; RUN: not llvm-profdata merge %t/memprof-invalid.yaml -o %t/memprof-invalid.indexed |
snehasish deleted the revert-142718-users/snehasish/06-03-_memprof_drop_unneccessary_requires_x86-linux_directives branch Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Reverts #142718
Breaks ppc aix builds: https://lab.llvm.org/buildbot/#/builders/64/builds/4036