[mlir][async][nfc] fix typo in op description #143621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| @llvm/pr-subscribers-mlir-async Author: Javed Absar (javedabsar1) ChangesFull diff: https://github.com/llvm/llvm-project/pull/143621.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/Async/IR/AsyncOps.td b/mlir/include/mlir/Dialect/Async/IR/AsyncOps.td index 3d29d5bc7dbb6..6dbcdefbc9332 100644 --- a/mlir/include/mlir/Dialect/Async/IR/AsyncOps.td +++ b/mlir/include/mlir/Dialect/Async/IR/AsyncOps.td @@ -376,7 +376,7 @@ def Async_CreateGroupOp : Async_Op<"create_group", [Pure]> { } def Async_AddToGroupOp : Async_Op<"add_to_group", []> { - let summary = "adds and async token or value to the group"; + let summary = "adds an async token or value to the group"; let description = [{ The `async.add_to_group` adds an async token or value to the async group. Returns the rank of the added element in the group. This rank is fixed @@ -655,7 +655,7 @@ def Async_RuntimeLoadOp : Async_Op<"runtime.load", } def Async_RuntimeAddToGroupOp : Async_Op<"runtime.add_to_group", []> { - let summary = "adds and async token or value to the group"; + let summary = "adds an async token or value to the group"; let description = [{ The `async.runtime.add_to_group` adds an async token or value to the async group. Returns the rank of the added element in the group. |
Member
| @llvm/pr-subscribers-mlir Author: Javed Absar (javedabsar1) ChangesFull diff: https://github.com/llvm/llvm-project/pull/143621.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/Async/IR/AsyncOps.td b/mlir/include/mlir/Dialect/Async/IR/AsyncOps.td index 3d29d5bc7dbb6..6dbcdefbc9332 100644 --- a/mlir/include/mlir/Dialect/Async/IR/AsyncOps.td +++ b/mlir/include/mlir/Dialect/Async/IR/AsyncOps.td @@ -376,7 +376,7 @@ def Async_CreateGroupOp : Async_Op<"create_group", [Pure]> { } def Async_AddToGroupOp : Async_Op<"add_to_group", []> { - let summary = "adds and async token or value to the group"; + let summary = "adds an async token or value to the group"; let description = [{ The `async.add_to_group` adds an async token or value to the async group. Returns the rank of the added element in the group. This rank is fixed @@ -655,7 +655,7 @@ def Async_RuntimeLoadOp : Async_Op<"runtime.load", } def Async_RuntimeAddToGroupOp : Async_Op<"runtime.add_to_group", []> { - let summary = "adds and async token or value to the group"; + let summary = "adds an async token or value to the group"; let description = [{ The `async.runtime.add_to_group` adds an async token or value to the async group. Returns the rank of the added element in the group. |
matthias-springer approved these changes Jun 11, 2025
tomtor pushed a commit to tomtor/llvm-project that referenced this pull request Jun 14, 2025
akuhlens pushed a commit to akuhlens/llvm-project that referenced this pull request Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.