[flang][test] Enable kinds01/02.f90 and update expected output #146877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
These have not been run in a while because they required the "x86_64" target but it's not called that, it's just "x86". After fixing that, 02 had some failures. I've just updated it to match, and reviewers will hopefully tell me if that's correct.
DavidSpickett changed the title 
llvmbot added flang 
Member
| @llvm/pr-subscribers-flang-semantics Author: David Spickett (DavidSpickett) ChangesThese have not been run in a while because they required the "x86_64" target but it's not called that, it's just "x86". After fixing that, 02 had some failures. I've just updated it to match, and reviewers will hopefully tell me if that's correct. Full diff: https://github.com/llvm/llvm-project/pull/146877.diff 2 Files Affected:
diff --git a/flang/test/Semantics/kinds01.f90 b/flang/test/Semantics/kinds01.f90 index 82c4d76da3710..ef822f5fbcbf0 100644 --- a/flang/test/Semantics/kinds01.f90 +++ b/flang/test/Semantics/kinds01.f90 @@ -1,5 +1,5 @@ -! REQUIRES: x86_64-registered-target -! RUN: %python %S/test_symbols.py %s %flang_fc1 +! REQUIRES: x86-registered-target +! RUN: %python %S/test_symbols.py %s %flang_fc1 -triple x86_64-unknown-linux-gnu !DEF: /MainProgram1/jk1 ObjectEntity INTEGER(1) integer(kind=1) jk1 !DEF: /MainProgram1/js1 ObjectEntity INTEGER(1) diff --git a/flang/test/Semantics/kinds02.f90 b/flang/test/Semantics/kinds02.f90 index 02b1e6c8c310a..d018b69f81f76 100644 --- a/flang/test/Semantics/kinds02.f90 +++ b/flang/test/Semantics/kinds02.f90 @@ -1,5 +1,5 @@ -! REQUIRES: x86_64-registered-target -! RUN: %python %S/test_errors.py %s %flang_fc1 +! REQUIRES: x86-registered-target +! RUN: %python %S/test_errors.py %s %flang_fc1 -triple x86_64-unknown-linux-gnu ! C712 The value of scalar-int-constant-expr shall be nonnegative and ! shall specify a representation method that exists on the processor. ! C714 The value of kind-param shall be nonnegative. @@ -44,9 +44,9 @@ complex(kind=32) :: z32 !ERROR: COMPLEX*1 is not a supported type complex*1 :: zs1 -!ERROR: COMPLEX*2 is not a supported type +!ERROR: COMPLEX(KIND=1) is not a supported type complex*2 :: zs2 -!ERROR: COMPLEX*64 is not a supported type +!ERROR: COMPLEX(KIND=32) is not a supported type complex*64 :: zs64 !ERROR: LOGICAL(KIND=0) is not a supported type logical(kind=0) :: l0 |
DavidSpickett commented Jul 3, 2025
| !ERROR: COMPLEX(KIND=1) is not a supported type | ||
| complex*2 :: zs2 | ||
| !ERROR: COMPLEX*64 is not a supported type | ||
| !ERROR: COMPLEX(KIND=32) is not a supported type |
Collaborator Author
There was a problem hiding this comment.
This is what we get now, I don't know if that's actually correct though.
Collaborator Author
| kinds01 is failing CI but passing on my AArch64 Linux machine, though I would expect it to pass anywhere because of the -target. https://github.com/llvm/llvm-project/actions/runs/16051206281?pr=146877 Perhaps this part of flang is still not cross compilation aware? |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
These have not been run in a while because they required the "x86_64" target but it's not called that, it's just "x86".
After fixing that, 02 had some failures. I've just updated it to match, and reviewers will hopefully tell me if that's correct.