[PATCH 2/7] [clang] improve NestedNameSpecifier: misc small clang changes #148012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mizvekov requested review from Sirraide, cor3ntin, erichkeane, shafik and zyn0217 mizvekov requested review from QuietMisdreavus, cyndyishida and daniel-grumberg as code owners 
llvmbot added clang 
Contributor
DeinAlptraum left a comment
DeinAlptraum left a comment There was a problem hiding this comment.
Re: Python bindings changes.
The tests currently fail because the libclang.so cannot even be built. Is this expected, as in, can it only be built after the last patch again? (I see that the tests passed on patch 6/6).
This should also probably get an entry in the bindings' breaking changes section of the release notes.
erichkeane approved these changes Jul 21, 2025
Collaborator
erichkeane left a comment
erichkeane left a comment There was a problem hiding this comment.
I did as in depth of a review of this as I could, nothing sticks out to me.
Contributor Author
Yes, but all of the patches will be squashed before merging.
Will do, thanks. |
mizvekov force-pushed the users/mizvekov/name-qualification-refactor-2 branch from 365a333 to 32e2a03 Compare mizvekov force-pushed the users/mizvekov/name-qualification-refactor branch from d8acbe8 to 58b801e Compare mizvekov force-pushed the users/mizvekov/name-qualification-refactor-2 branch from 32e2a03 to d265b06 Compare mizvekov changed the title mizvekov changed the title mizvekov changed the title mizvekov force-pushed the users/mizvekov/name-qualification-refactor branch from 58b801e to dcef00f Compare mizvekov force-pushed the users/mizvekov/name-qualification-refactor-2 branch from d265b06 to b6b18fb Compare mizvekov force-pushed the users/mizvekov/name-qualification-refactor-2 branch from b6b18fb to d993682 Compare mizvekov force-pushed the users/mizvekov/name-qualification-refactor branch from dcef00f to 7da952b Compare mizvekov force-pushed the users/mizvekov/name-qualification-refactor-2 branch from d993682 to 89c515f Compare mizvekov force-pushed the users/mizvekov/name-qualification-refactor branch from 7da952b to 9a9b252 Compare 
…nges Other changes Second patch in the series starting at #147835
mizvekov force-pushed the users/mizvekov/name-qualification-refactor-2 branch from 89c515f to 60921a7 Compare mizvekov force-pushed the users/mizvekov/name-qualification-refactor branch from 9a9b252 to 80f2f57 Compare clang test changes Third patch in the series, starting at #147835
mizvekov merged commit 95d0060 into users/mizvekov/name-qualification-refactor 8 of 11 checks passed
llvmbot added clang-tools-extra libc++ Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Other changes
Second patch in the series starting at #147835