[flang][Lower] fix warning #148667
Merged
[flang][Lower] fix warning #148667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
GCC 9.3.0 ``` .../flang/lib/Lower/Support/ReductionProcessor.cpp:137:1: error: control reaches end of non-void function [-Werror=return-type] ```
llvmbot added flang 
klausler approved these changes Jul 14, 2025
Member
| @llvm/pr-subscribers-flang-fir-hlfir Author: Tom Eccles (tblah) ChangesGCC 9.3.0 Full diff: https://github.com/llvm/llvm-project/pull/148667.diff 1 Files Affected:
diff --git a/flang/lib/Lower/Support/ReductionProcessor.cpp b/flang/lib/Lower/Support/ReductionProcessor.cpp index 77cb15a2a77ca..c0be1e229f825 100644 --- a/flang/lib/Lower/Support/ReductionProcessor.cpp +++ b/flang/lib/Lower/Support/ReductionProcessor.cpp @@ -134,6 +134,7 @@ ReductionProcessor::getReductionType(const fir::ReduceOperationEnum &redOp) { case fir::ReduceOperationEnum::MIN: return ReductionIdentifier::MIN; } + llvm_unreachable("Unhandled ReductionIdentifier case"); } bool ReductionProcessor::supportedIntrinsicProcReduction( |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
GCC 9.3.0