Skip to content

Conversation

@kparzysz
Copy link
Contributor

No description provided.

@kparzysz kparzysz requested review from mjklemm and skc7 August 14, 2025 17:33
@llvmbot llvmbot added flang:driver flang Flang issues not falling into any other category flang:openmp clang:openmp OpenMP related changes to Clang labels Aug 14, 2025
@llvmbot
Copy link
Member

llvmbot commented Aug 14, 2025

@llvm/pr-subscribers-flang-driver

@llvm/pr-subscribers-flang-openmp

Author: Krzysztof Parzyszek (kparzysz)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/153628.diff

2 Files Affected:

  • (modified) flang/test/Driver/fopenmp-version.F90 (+1-1)
  • (modified) llvm/lib/Frontend/OpenMP/OMP.cpp (+1-1)
diff --git a/flang/test/Driver/fopenmp-version.F90 b/flang/test/Driver/fopenmp-version.F90 index c2866561461b7..48b6ddca772c3 100644 --- a/flang/test/Driver/fopenmp-version.F90 +++ b/flang/test/Driver/fopenmp-version.F90 @@ -22,4 +22,4 @@ !RUN: not %flang -c -fopenmp -fopenmp-version=29 %s 2>&1 | FileCheck --check-prefix=ERR-BAD %s -!ERR-BAD: error: '29' is not a valid OpenMP version in '-fopenmp-version=29', valid versions are 31, 40, 45, 50, 51, 52, 60 +!ERR-BAD: error: '29' is not a valid OpenMP version in '-fopenmp-version=29', valid versions are 31, 40, 45, 50, 51, 52, 60, 61 diff --git a/llvm/lib/Frontend/OpenMP/OMP.cpp b/llvm/lib/Frontend/OpenMP/OMP.cpp index 555e2a61e411e..9e625b809de9e 100644 --- a/llvm/lib/Frontend/OpenMP/OMP.cpp +++ b/llvm/lib/Frontend/OpenMP/OMP.cpp @@ -190,7 +190,7 @@ bool isCombinedConstruct(Directive D) { } ArrayRef<unsigned> getOpenMPVersions() { - static unsigned Versions[]{31, 40, 45, 50, 51, 52, 60}; + static unsigned Versions[]{31, 40, 45, 50, 51, 52, 60, 61}; return Versions; } 
Copy link
Contributor

@mjklemm mjklemm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjklemm mjklemm self-requested a review August 14, 2025 18:24
Copy link
Contributor

@mjklemm mjklemm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please emit a warning when 6.1 is being selected?

@kparzysz
Copy link
Contributor Author

Sure, give me a few minutes...

@kparzysz
Copy link
Contributor Author

The warning is The specification for OpenMP 61 is still under development; the behavior of new features is subject to change

Copy link
Contributor

@mjklemm mjklemm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the wording nits are addressed.

kparzysz and others added 3 commits August 18, 2025 08:11
Co-authored-by: Michael Klemm <michael.klemm@amd.com>
Co-authored-by: Michael Klemm <michael.klemm@amd.com>
@kparzysz kparzysz merged commit ae75884 into llvm:main Aug 18, 2025
9 checks passed
@kparzysz kparzysz deleted the users/kparzysz/omp-version-61 branch August 18, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang:openmp OpenMP related changes to Clang flang:driver flang:openmp flang Flang issues not falling into any other category

3 participants