Skip to content

[OpenMP] Rename z_Linux files to z_OS #157190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[OpenMP] Rename z_Linux files to z_OS #157190

wants to merge 1 commit into from

Conversation

@brad0
Copy link
Contributor

@brad0 brad0 commented Sep 5, 2025

Rename the files as the contents are already supporting a range of OSes
other than Linux.
@brad0
[OpenMP] Rename z_Linux files to z_OS
ccedc56 
Rename the files as the contents are already supporting a range of OSes other than Linux.
@brad0 brad0 requested a review from shiltian September 5, 2025 22:33
@llvmbot llvmbot added the openmp:libomp OpenMP host runtime label Sep 5, 2025
shiltian
shiltian reviewed Sep 8, 2025
View reviewed changes
Copy link
Contributor

@shiltian shiltian left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO this just makes it more confusing. True, the "Linux" file isn't only for Linux, but it might be pretty clear that it's for non-Windows, especially since we already have a Windows counterpart.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

openmp:libomp OpenMP host runtime

3 participants

@brad0 @shiltian @llvmbot